podaboutlist / linkfix-for-discord

LinkFix brings link embeds back to your Discord server! Simply post Twitter, Instagram, TikTok, or Reddit links and LinkFix will reply with a rich media embed.
https://discord.com/application-directory/385950397493280805
GNU Affero General Public License v3.0
18 stars 5 forks source link

`pixiv.net` -> `phixiv.net` replacement no longer working #23

Closed ryln7218 closed 11 months ago

ryln7218 commented 11 months ago

As the title suggests, replying to pixiv.net links with either images of the arts/files in the link or even a simple phixiv.net link would be great! The former might be hard to implement (the only bot I saw that could do this was Boe Tea) but hopefully the latter follows the same logic as all the other links!

Thanks

ryln7218 commented 11 months ago

Also sorry I don't know how to add tags to this post

RalphORama commented 11 months ago

I have not used Pixiv before but I'll look into it! Is there a separate fx/vxtwitter site or are you talking about direct image links?

RalphORama commented 11 months ago

After a cursory look it doesn't appear there are any sites like vxpixiv.net or fxpixiv.net that do this already. I could probably add a feature that loads the page and extracts the direct image URL, but #19 is currently taking up most of my time. Once database support is finished I'll look into this again!

ryln7218 commented 11 months ago

I was talking about direct image links but if that is too hard, similar to fx/vx twitter phixiv exists for pixiv (note the addition of 'h') although it's not a large improvement from just pixiv embeds... (1st image just pixiv, 2nd image phixiv)

On Sun, 31 Dec 2023, 6:09 pm Ralph Drake, @.***> wrote:

After a cursory look it doesn't appear there are any sites like vxpixiv.net or fxpixiv.net that do this already. I could probably add a feature that loads the page and extracts the direct image URL, but #19 https://github.com/podaboutlist/linkfix-for-discord/pull/19 is currently taking up most of my time. Once database support is finished I'll look into this again!

— Reply to this email directly, view it on GitHub https://github.com/podaboutlist/linkfix-for-discord/issues/23#issuecomment-1872746871, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFAXT6GNO7ZCY6J7FCILOXLYMEFSBAVCNFSM6AAAAABBIA5QBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSG42DMOBXGE . You are receiving this because you authored the thread.Message ID: @.***>

RalphORama commented 11 months ago

Unfortunately it looks like they have image hotlinking protection in place so direct image links won't load on Discord. I will add functionality for phixiv, but it would be fairly complicated to grab full resolution images.

The other bot you mentioned probably downloads/re-uploads the image using a burner account which is way more complicated than what I'd like to implement lol

RalphORama commented 11 months ago

Functionality added! I don't use Pixiv very much so if you encounter any issues with LinkFix and Pixiv, please feel free to open another issue

ryln7218 commented 11 months ago

It worked for a bit when you added it but now it doesn't seem to work...? sent a link such as "https://www.pixiv.net/artworks/114853941" on discord where the bot has access to and no reply with a phixiv link.... All other features (twitter --> fx) still work as intended.

RalphORama commented 11 months ago

Think I might have screwed up the regex at some point. I'll look into it. Thanks for letting me know!

RalphORama commented 11 months ago

@ryln7218 just pushed an update that should fix Pixiv replacements. thanks for letting me know about the issue!