podcodar / voting-system

voting-system-lyart.vercel.app

1 stars 0 forks source link

Feat: create input panel #27

Closed borgesgfj closed 2 years ago

borgesgfj commented 2 years ago

Description

Create the basic input panel layout with numeric and actions buttons, also apply some changes to the Base Button component.

Follows a print of the voting page current state

Changes

Change the padding property of the BaseButton component to be paddingY which controls just the vertical padding
Set the BaseButton width to be fully controlled by its parent element.

Board issue

closes #1

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
voting-system	✅ Ready (Inspect)	Visit Preview	Jul 31, 2022 at 6:16PM (UTC)

borgesgfj commented 2 years ago

Boa Gil! Apenas pequenos comments complementando ao dos meninos!

Good one! I just keep the button text as a string, I don't know to explain why, but for some reason (TOC maybe hahaha) I do prefer to keep this as a string. Is that a problem?

frattezi commented 2 years ago

Ae GIl, ficou muito show!

Man, parece que deu um conflitinho, também quero deixar aqui um comment que deixei ali pro mamão que tu mata na mema hora:

" Adicionar um todo aqui como comentário, na linha nove:

"TODO(Mamao): Move to centralized theme" ". Acho que cabe aqui também e fechadmos isso.

Matando isso morreu, bora pro merge!

borgesgfj commented 2 years ago

lgtm! just think these BaseButton's could use some padding

It already use it, please note the image in the PR description.

In fact there is a good reason to set just padding in vertical direction. We can talk more about it :)

borgesgfj commented 2 years ago

lgtm! just think these BaseButton's could use some padding

Ow man, now I understood what is happening, I was working on an outdated main. and its ugly behavior emerges when I updated and use the VotingInstructions. I will fix that!