podgorskiy / GPND

Generative Probabilistic Novelty Detection with Adversarial Autoencoders
129 stars 31 forks source link

Reduce hardcoded input and output shapes #3

Open 2martens opened 5 years ago

2martens commented 5 years ago

In the train_AAE.py file a zsize of 32 is defined. But it is not consistently used. Sometimes the number 32 is used directly which makes it difficult to modify the code for different image sizes.

It would be helpful if you could clearly use variables designated channels, height, width and zsize (should that be different from height/width) instead of hardcoded values wherever channels, height, width or zsize are effectively used. This should be applied to the network definitions as well.

This would make it significantly easier to port your work to other datasets and/or Tensorflow/Keras.