search

podhmo / python-node-semver

python version of node-semver
MIT License
21 stars 15 forks source link

Pre release range fix #40

Closed raphaelzulliger closed 3 years ago

raphaelzulliger commented 4 years ago

This merge request fixes a bunch of issues with 'range checks'. It therefore adds several tests along with a proposed fix.

I compared the behavior with node-semver and by this PR, we'd come much closer to its behavior.

I'm not sure how the version of this Python module should be handled: While it's a bugfix, it certainly may affect existing software out there... such as Conan packages. Therefore, an increase in major should be considered.

See also the issue /issues/37

podhmo commented 3 years ago

Sorry for late response. OK. This changes is a bit danger, right?. if upload the version include this change, update major version.