Default Dark Theme removes "Subscribe" button

smacz42 commented 4 years ago

When using the value "default-dark" for the option "theme" in the "options" section of the configuration, the "Subscribe" button disappears. See https://jsfiddle.net/0v3ar1mb/113/ for a version with a subscribe button, and https://jsfiddle.net/0v3ar1mb/114/ for one without.

A demo config is here:

    window.config = {
  "episode": {
    "media": {
      "mp3": "https://dev.ourcompose.com/jekyll/assets/audio/episode-3-kanboard-a-kanban-board.mp3",
    },
  },
  "podcast": {
    "feed": "https://dev.ourcompose.com/jekyll/feed.xml",
    "connections": {},
  },
  "extensions": {
    "SubscribeBar": {
      "disabled": false
    }
  },
  options: {
    theme: "default-dark"
  }
    }

That is as minimal as I could get. Changing options.theme from default to default-dark removes the "Subscribe" button.

Expected Behavior

The default dark theme shows the subscribe button.

smacz42 commented 4 years ago

As a side note, I also don't see the podcast.connections option documented anywhere, which I believe is required for a working "Subscribe" button.

rodrigoaguilera commented 3 years ago

From https://github.com/podigee/podigee-podcast-player/blob/80fe5fb8e1d769d4298edd887dd47ea1b946fd78/src/themes/default/index.html#L52

I discovered that is just a structure with spotify, itunes, etc as keys and the services URLs as values inside the connections key.

For the url of "all episodes" you need a url key that is a sibling of connections.

But anyway this is only configured to show in the default theme as you point out.

podigee / podigee-podcast-player

Default Dark Theme removes "Subscribe" button #89

Expected Behavior