search

podio / jquery-mentions-input

MIT License
985 stars 333 forks source link

IE8 won't fire the "input" event on textarea, so bind to "propertychange" instead to make it work #122

Closed gil closed 9 years ago

auchenberg commented 9 years ago

This should happen outside of mentionsInput with an input event polyfill, like http://benalpert.com/2013/06/18/a-near-perfect-oninput-shim-for-ie-8-and-9.html

The aim here is to avoid browser specific hacks/events, but simply rely on the standards, which then can be polyfilled in older browsers.

djhvscf commented 9 years ago

Yes, @auchenberg is right!! We want to avoid the browser specifications

gil commented 9 years ago

Sorry, I didn't know this was the mindset, because of this: https://github.com/podio/jquery-mentions-input/blob/f0efedd2447bc071f3766e280cb084bd9e48de57/jquery.mentionsInput.js#L269-L274

So maybe we can remove that later, and suggest the polyfill at the README.

djhvscf commented 9 years ago

Yes, you're right.. so let me check if we can merge this pull request! @gil

gil commented 9 years ago

We can close this pull request if you guys want, and think about the other IE9 fix later. I feel that polyfill would be a better solution.

djhvscf commented 9 years ago

Sure. @gil