Fix query parameter used for GET /app/{app_id}

podio / podio-dotnet

Podio .NET client

MIT License

19 stars 39 forks source link

Fix query parameter used for GET /app/{app_id} #36

Closed sagart closed 7 years ago

sagart commented 7 years ago

Fix query parameter "type" -> "view" for GET /app/{app_id}, irrespective of what we pass for "type", we were receiving the same response. Changing it to "view" honors the view types correctly.
Adding "Space" to Application Model
Make the App Get API more generic to accept additional parameters (key, value pairs)

sagart commented 7 years ago

@rgmills - sample value for "fields" query param is some thing like "space.view(full)", have mentioned it in documentation..

sagart commented 7 years ago

@crochik - the generic key/value pairs was recommended by @PavloBasiuk based on the ruby library. Also note that we are also setting the default view as full in case they don't pass any params.

PavloBasiuk commented 7 years ago

With single additionalOptions parameter this call will be 1-to-1 match with Podio Ruby SDK: https://github.com/podio/podio-rb/blob/master/lib/podio/models/application.rb#L47