Missing image size type in getThumbnailURLForFileLink

podio / podio-js

Official Podio JavaScript SDK for node and the browser

http://podio.github.io/podio-js/

MIT License

45 stars 49 forks source link

Missing image size type in getThumbnailURLForFileLink #42

Closed fisettec closed 8 years ago

fisettec commented 8 years ago

Hi,

the ALLOWED_SIZES array in function getThumbnailURLForFileLink (general.js) is missing the "extra_large" image size. This size is useful to use in place of the native big resolution-multi-mb pictures put in Podio by some users ;) It's good enough to save us the trouble of resizing the picture in node with the like of ImageMagick.

Suggested correction, general.js, line 12: var ALLOWED_SIZES = ['badge', 'extra_large', 'large', 'medium', 'small', 'tiny'];

dmatteo commented 8 years ago

Implemented.

Thanks for the report, and sorry for the long wait.

dmatteo commented 8 years ago

published as 1.4.3