search

podio / podio-rb

The official Ruby wrapper for the Podio API used and maintained by the Podio team
https://podio.com
MIT License
66 stars 52 forks source link

Rails 4 support #12

Closed conf closed 10 years ago

conf commented 10 years ago

Hi!

Any chance to make Podio run on Rails 4? It seems completely incompatible for now :(

RSpace commented 10 years ago

We probably won't have time to look at that before we upgrade to Rails 4 ourselves, which is not on the roadmap right now. A pull request would be much appreciated :)

I'd also be interested to hear what exactly is the problem - is it gem dependencies or something in the actual podio-rb code?

conf commented 10 years ago

Thank you for a quick answer. For now it seems to be just gem dependencies, I've changed activesupport and activemodel to ~> 4.0 and it seems to work fine, although we use only a tiny bit of Podio API (find_by_filter_values method), but maybe with time we'll need more :) Tests also pass:

admin@shein /tmp/podio-rb (master=) $ rake 
/Users/admin/.rvm/rubies/ruby-2.0.0-p353/bin/ruby -I"lib:lib:test" -rubygems -I"/Users/admin/.rvm/gems/ruby-2.0.0-p353@global/gems/rake-10.1.1/lib" "/Users/admin/.rvm/gems/ruby-2.0.0-p353@global/gems/rake-10.1.1/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Run options: 

# Running tests:

Finished tests in 0.173548s, 875.8384 tests/s, 1060.2254 assertions/s.                                                      
152 tests, 184 assertions, 0 failures, 0 errors, 0 skips

ruby -v: ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-darwin12.5.0]

Could you make a separate branch for Rails 4.0 so I can reference it in my project's Gemfile? This way it'll be easier to send (and merge :)) pull requests too.

RSpace commented 10 years ago

Sure, there's a rails4 branch now. Would be great if you could do a pull request against that :)

RSpace commented 10 years ago

Thanks a lot for your pull request, it has been merged to the rails4 branch now! :+1: