Updated faraday to 0.9.0

[webhat]

Due to a undocumented feature in faraday it was possible to pass objects around by using the RequestOption struct, like this:

    env[:request][:client] = self

This undocumented feature this broke as of 0.9.0.

I patched it using a singleton in the Podio::Client.

[RSpace]

Thanks for the pull request. Please remove the change to the license file. If you want recognition, you can add a collaborators file and put your name there.

[webhat]

:+1:

[RSpace]

Thanks for the update. Since Podio always runs on the newest version of this repo, I need to make sure we are compatible with faraday 0.9.0 before I can merge this in. Work in progress ...

[webhat]

As it's also been tested against faraday ~> 0.8.0 you could change the spec to ~> 0.8 and have projects that include it chose explicitly or implicitly which version of faraday to use.

[RSpace]

Hm, your branch didn't work for me against Faraday 0.8.9. I'm getting undefined method `current_http_client=' for nil:NilClass, but could be that that is a related dependency.

[webhat]

That is odd, I just ran all the tests locally against ruby-2.0.0-p481 and ruby-1.9.3-p547, could you post a trace?

ruby-2.0.0-p481

Tests

rake
/Users/webhat/.rvm/rubies/ruby-2.0.0-p481/bin/ruby -I"lib:lib:test" -rubygems -I"/Users/webhat/.rvm/gems/ruby-2.0.0-p481/gems/rake-10.3.2/lib" "/Users/webhat/.rvm/gems/ruby-2.0.0-p481/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Run options: 

# Running tests:

Finished tests in 0.088376s, 1799.1310 tests/s, 2161.2202 assertions/s.                                                
159 tests, 191 assertions, 0 failures, 0 errors, 0 skips

Gems:

$ bundle list
Gems included by the bundle:
  * activemodel (4.0.12)
  * activesupport (4.0.12)
  * builder (3.1.4)
  * bundler (1.6.2)
  * faraday (0.8.9)
  * i18n (0.6.11)
  * minitest (4.7.5)
  * multi_json (1.10.1)
  * multipart-post (1.2.0)
  * podio (1.0.0)
  * rake (10.3.2)
  * thread_safe (0.3.4)
  * tzinfo (0.3.42)
  * yard (0.8.7.6)

ruby-1.9.3-p547

Tests:

/Users/webhat/.rvm/rubies/ruby-1.9.3-p547/bin/ruby -I"lib:lib:test" -rubygems -I"/Users/webhat/.rvm/gems/ruby-1.9.3-p547/gems/rake-10.3.2/lib" "/Users/webhat/.rvm/gems/ruby-1.9.3-p547/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Run options: 

# Running tests:

...............................................................................................................................................................

Finished tests in 0.062074s, 2561.4589 tests/s, 3076.9726 assertions/s.

159 tests, 191 assertions, 0 failures, 0 errors, 0 skips

Gems:

$ bundle list
Gems included by the bundle:
  * activemodel (4.0.12)
  * activesupport (4.0.12)
  * builder (3.1.4)
  * bundler (1.7.7)
  * faraday (0.8.9)
  * i18n (0.6.11)
  * minitest (4.7.5)
  * multi_json (1.10.1)
  * multipart-post (1.2.0)
  * podio (1.0.0)
  * rake (10.3.2)
  * thread_safe (0.3.4)
  * tzinfo (0.3.42)
  * yard (0.8.7.6)

[webhat]

ping

[webhat]

Any movement on this?

[theflow]

Sorry this took so long. Fixed in 65da2839bbed01624c23e55e056b4ab557950ad2

[webhat]

Great stuff!