search

podio / podio-rb

The official Ruby wrapper for the Podio API used and maintained by the Podio team
https://podio.com
MIT License
66 stars 53 forks source link

Outdated Faraday dependency #48

Closed dukeimg closed 6 years ago

dukeimg commented 7 years ago

Hi. Hope you're doing great!

In the project you have a dependency:

s.add_dependency('faraday', ['>= 0.8.0', '< 0.10.0'])

And I want to use podio-rb along with another gem that requires Faraday >= 0.12.0.

Do you have any plans on upgrading Faraday dependency?

cpeters commented 7 years ago

Use bundler to manage various gems and their dependencies.

http://bundler.io/gemfile.html

dukeimg commented 7 years ago

It won't work for me because I will have to include 2 different versions of Faraday to my Rails project the same time :D

cpeters commented 7 years ago

That's exactly why you use bundler.

dukeimg commented 7 years ago

I apologize, I forgot to mention that gem 'faraday', '~> 0.12.0.1' is also required in Gemfile because it is directly used in the project for some requests. So I can't really resolve this dependency issue.

Bundler could not find compatible versions for gem "faraday":
  In Gemfile:
    faraday (~> 0.12.0.1)

    podio (>= 2.0.0) was resolved to 2.0.0, which depends on
      faraday (< 0.10.0, >= 0.8.0)
cpeters commented 7 years ago

I see. We don't currently have any plans to upgrade faraday. If you'd like to do the upgrade and create a pull request I will gladly review it and release an update to the podio gem.

dukeimg commented 7 years ago

Well, I tried to upgrade dependency today and it seem that podio-rb still passes all tests. I will create a pull request then.