search

podio / requirejs-react-jsx

A RequireJS plugin for loading jsx in development and compiling (with r.js). Supports bundling and 1:1 source maps in development and production.
MIT License
104 stars 20 forks source link

Proper support of RequireJS config #10

Closed kirill-konshin closed 9 years ago

kirill-konshin commented 9 years ago

Fix for https://github.com/podio/requirejs-react-jsx/issues/9

srn commented 9 years ago

Great, thanks. I'm not really sure I want to keep the deprecated support around though, I think we should just remove it and let the user read the docs instead.

Munter commented 9 years ago

Just major version bump. Semver will tell people to watch out

kirill-konshin commented 9 years ago

Do you want me to remove it or you'll do it yourself when you'll bump a version?

kirill-konshin commented 9 years ago

So will this be merged?

srn commented 9 years ago

Thanks for the PR :ok_hand:

kirill-konshin commented 9 years ago

You are welcome :)

srn commented 9 years ago

Also published to npm: https://github.com/podio/requirejs-react-jsx/commit/8eaa0847cebd755341528cc0c73f6048cf5e8f44

kirill-konshin commented 9 years ago

Can you also update bower.json?

Munter commented 9 years ago

We're not updating version numbers in bower.json. Using git tags instead. But v0.14.0 was missing. Fixed now