search

podkrepi-bg / frontend

Charity platform https://podkrepi.bg Docs https://docs.podkrepi.bg
https://podkrepi.bg
MIT License
177 stars 88 forks source link

Bugfix/new donation flow issues #1962

Closed nikolay-yankov closed 3 weeks ago

nikolay-yankov commented 1 month ago

Motivation and context

Fixes several issues from ticket #1960 related to the new donation flow, discovered during QA testing.

Screenshots:

Issue # Before After
1 image image
2 image image
3 Cannot reproduce - message sent to QA for details N/A
4 image imageimage
5 image Yes, it should work exactly the opposite way. Now when the user selects the X button or Cancel button, the user remains on the same page. If the user selects Continue button, then it will be redirected to the Campaign preview page.
10 image image
11 image image
12 image image

Additional change:

IMO we should not disable the Amount field when bank payment option is selected as this creates several side effect. IMO we should either hide it completely when Bank options is chosen or leave it always available. This is because currently, if the user selects an amount and then selects bank payment type, the Amount field becomes disabled. This could create some confusion because the user cannot change the amount anymore and they cannot use the calculator for amount + fees at the bottom. Also if validation is triggered and the field, they cannot select an option to continue with the donation. Here I removed the option for disabling in commit https://github.com/podkrepi-bg/frontend/commit/2ceeef55f2826e3ac9e43e81b25c8d28021b1d9e

github-actions[bot] commented 1 month ago

✅ Tests will run for this PR. Once they succeed it can be merged.