Episodenansicht: Falsche Staffelnummer

christianmondabon commented 5 years ago

Expected behavior

In der Episodenansicht sollte die korrekte Staffelnummer angezeigt werden.

Actual behavior

In der Episodenansicht wird für alle Episoden jeweils die Staffelnummer 1 angezeigt.

podlove-staffeln episodenansicht

System information (see `Podlove > Support` menu)

Website https://chaosradio.de PHP Version 7.2.11 WordPress Version 4.9.8 WordPress Theme Twenty Eleven v2.8 Active Plugins

All-in-One Event Calendar von Time.ly v2.5.32
Antispam Bee v2.9.0
Better Font Awesome v1.7.1
Check Email v0.5.5
Fast Velocity Minify v2.3.5
German Slugs v0.2
Chaosradio-Links v0.1
Insert Headers and Footers v1.4.3
Nginx Helper v1.9.12
Podlove Podcast Publisher v2.7.16
WP DSGVO Tools v2.1.3
Twenty Eleven Theme Extensions v1.2
UpdraftPlus - Backup/Restore v1.15.3
Username Changer v3.1.3
WordPress Importer v0.6.4
WordPress phpinfo() v16.3 WordPress Database Charset utf8mb4 WordPress Database Collate Publisher Version 2.7.16 Web Player Version player_v4 Twig Version 1.35.3 open_basedir ok curl Version 7.62.0 iconv available simplexml ok max_execution_time 30 upload_max_filesize 10M memory_limit 256M disable_classes
disable_functions
permalinks ok (/%postname%) podlove_permalinks ok podcast_settings ok web_player ok podlove_cache on assets
- mp3 audio/mpeg https://chaosradio.de/feed/mp3 - m4a audio/mp4 https://chaosradio.de/feed/m4a - opus audio/ogg;codecs=opushttps://chaosradio.de/feed/opus cron ok

0 errors 0 notices Nice, Everything looks fine!

christianmondabon commented 5 years ago

Auch im Feed wird zu allen Episoden Staffelnummer 1 publiziert.

eteubert commented 5 years ago

Can you send me an CSV or SQL export of your wp_podlove_modules_seasons_season table? Can't reproduce it here.

danimo commented 5 years ago

> select * from wp_podlove_modules_seasons_season;
+----+-------+----------+---------+-------+------------+
| id | title | subtitle | summary | image | start_date |
+----+-------+----------+---------+-------+------------+
|  1 | NULL  | NULL     | NULL    | NULL  | 1995-01-01 |
|  2 | NULL  | NULL     | NULL    | NULL  | 1996-01-01 |
|  3 | NULL  | NULL     | NULL    | NULL  | 1997-01-01 |
|  4 | NULL  | NULL     | NULL    | NULL  | 1998-01-01 |
|  5 | NULL  | NULL     | NULL    | NULL  | 1999-01-01 |
|  7 | NULL  | NULL     | NULL    | NULL  | 2000-01-01 |
|  8 | NULL  | NULL     | NULL    | NULL  | 2002-01-01 |
|  9 | NULL  | NULL     | NULL    | NULL  | 2001-01-01 |
| 10 | NULL  | NULL     | NULL    | NULL  | 2003-01-01 |
| 11 | NULL  | NULL     | NULL    | NULL  | 2004-01-01 |
| 12 | NULL  | NULL     | NULL    | NULL  | 2005-01-01 |
| 13 | NULL  | NULL     | NULL    | NULL  | 2006-01-01 |
| 14 | NULL  | NULL     | NULL    | NULL  | 2007-01-01 |
| 15 | NULL  | NULL     | NULL    | NULL  | 2008-01-01 |
| 16 | NULL  | NULL     | NULL    | NULL  | 2009-01-01 |
| 17 | NULL  | NULL     | NULL    | NULL  | 2010-01-01 |
| 18 | NULL  | NULL     | NULL    | NULL  | 2011-01-01 |
| 19 | NULL  | NULL     | NULL    | NULL  | 2012-01-01 |
| 20 | NULL  | NULL     | NULL    | NULL  | 2013-01-01 |
| 21 | NULL  | NULL     | NULL    | NULL  | 2014-01-01 |
| 22 | NULL  | NULL     | NULL    | NULL  | 2015-01-01 |
| 23 | NULL  | NULL     | NULL    | NULL  | 2016-01-01 |
| 24 | NULL  | NULL     | NULL    | NULL  | 2017-01-01 |
| 25 | NULL  | NULL     | NULL    | NULL  | 2018-01-01 |
| 26 | NULL  | NULL     | NULL    | NULL  | 2019-01-01 |
+----+-------+----------+---------+-------+------------+
25 rows in set (0.000 sec)

Note: I manually applied ad5f9138a5bb0bdb3de3a0eefc74721865750d17 on top of 2.7.17.

danimo commented 5 years ago

bump, anything else we can do to help with this?

eteubert commented 5 years ago

Sorry, wasn't able to replicate it yet. The only noticeable thing about the dataset is that 2001 is out of order, but creating out-of-order seasons works fine for me. I'm out of ideas at the moment.

Backpackstudio commented 5 years ago

the same ptoblem here, invalid season number 1 instead of proper number.

Backpackstudio commented 5 years ago

I guess problem is hidden here:

    public function get_season_for_episode_id($episode_id)
    {
        foreach ($this->data as $season_id => $episode_ids) {
            if (in_array($episode_id, $episode_ids)) {
                return Season::find_by_id($season_id);
            }
        }
        return null;
    }

Backpackstudio commented 5 years ago

This issue is related to the issue #1064

podlove / podlove-publisher