podlove / podlove-web-player

Podlove Web Player is a Podcast-optimized, HTML5-based audio player based on VueJS.
https://docs.podlove.org/podlove-web-player/
Other
353 stars 68 forks source link

feat(tabs): change audio-tab icon to speaker symbol #848

Closed jgerhold closed 5 years ago

jgerhold commented 5 years ago

Changed audio-tab icon content to the speaker symbol (fixes #845)

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

codecov[bot] commented 5 years ago

Codecov Report

Merging #848 into development will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #848   +/-   ##
============================================
  Coverage        98.74%   98.74%           
============================================
  Files               79       79           
  Lines             1037     1037           
============================================
  Hits              1024     1024           
  Misses              13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ec71eb4...107ffa7. Read the comment docs.

alexander-heimbuch commented 5 years ago

Thanks for the contribution πŸ‘ One quick remark: the audio icon adapts to the current volume level. It would be great if the tab icon would also work in this manner.

jgerhold commented 5 years ago

The Audio tab icon is now dynamic too. πŸ™‚