search

podlove / podlove-web-player

Podlove Web Player is a Podcast-optimized, HTML5-based audio player based on VueJS.
https://docs.podlove.org/podlove-web-player/
Other
353 stars 68 forks source link

Userland "runtime" options are not merged with defaults #858

Closed jdreesen closed 5 years ago

jdreesen commented 5 years ago

The docs say that it's possible to set some runtime options.

But when the key runtime is present in the userland config it'll overwrite the default runtime config, which breaks1 several things because all keys of the default config get replaced by the ones given in the userland config.

The problem is, that it's not really desired to determine some of the values by hand (such as the clients browser or platform) or doesn't even make sense (like the version).

When I set the language config key to 'de'2, the other runtime config information is lost. To fix this, the user config should be merged with the default one.

1 For example: when only the runtime.language is set, the version doesn't get displayed in the audio tab anymore. Also the volume selector in the audio tab vanishes because the runtime.platform is not set (to desktop) anymore.

2 Other than stated in the documentation, the automatic language selection does not seem to work for me. But this seems to be another issue.

alexander-heimbuch commented 5 years ago

thanks for the report, I recently also detected a similar issue with the runtime and date/time related locales. Will investigate :)