Properly set post type param to fix issues with Polylang and possibly others.

pods-framework / pods-beaver-builder-themer-add-on

Integration of Beaver Themer plugin for WordPress (https://pods.io/beaver-themer/)

https://wordpress.org/plugins/pods-beaver-builder-themer-add-on/

GNU General Public License v2.0

35 stars 6 forks source link

Properly set post type param to fix issues with Polylang and possibly others. #117

Closed JoryHogeveen closed 2 years ago

JoryHogeveen commented 2 years ago

Second try PR :) Prev: #109

Setting the post type to any can cause edge case issues with other plugins and WP core.

For non-translatable post types this will create compatibility issues with Polyland since adding any will trigger Polylang to add the language queries, even though the ID's might not be translatable.

Other than that, setting any also affects WP default query to only include public posts. I can imagine edge cases where this might cause issues.

Added enhancement to the above for relationship fields.

quasel commented 2 years ago

looks god so far - but I'm a bit out of the loop ;) - hope to help out more soon again!

@sc0ttkclark any objections?

quasel commented 2 years ago

oh and if I remember correctly we should create a branch for the next release that then get's merged into main…

JoryHogeveen commented 2 years ago

@quasel No problem, maybe you can create a branche and name it as you like, perhaps the version number or just dev?

JoryHogeveen commented 2 years ago

@quasel @sc0ttkclark Let me know if there is anything else you need from me. It's been a while since the latest update from this plugin so I think this would be a good addition for compatibility.