pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.
https://pods.io/
GNU General Public License v2.0
1.07k stars 264 forks source link

Suddenly unable to see select boxes - by user role #4863

Closed ferbit closed 6 years ago

ferbit commented 6 years ago

Issue Overview

Some of my users suddenly reported today they couldn't see any select boxes in the pods I created for them. This is both simple custom defined lists as well as relational lists. I can see them just fine logging in as an admin, but as soon as I login as one of them, I can duplicate what's happening to them.

js debug missingfields-userrole no-missingfields-adminrole

Pods Package Export (helpful!)

{"meta":{"version":"2.7.1","build":1524611697},"pods":{"625":{"id":625,"name":"category","label":"Category","description":"","type":"taxonomy","storage":"meta","object":"category","alias":"","fields":{"counselor":{"id":626,"name":"counselor","label":"Counselor","description":"","help":"","class":"","type":"pick","weight":0,"pick_object":"post_type","pick_val":"team","sister_id":"","required":"0","pick_format_type":"single","pick_format_single":"dropdown","pick_format_multi":"checkbox","pick_allow_add_new":"1","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""}},"show_in_menu":1,"pfat_enable":"0","pfat_run_outside_loop":"0","pfat_append_archive":"append","rest_enable":"0","read_all":"0","write_all":"0","built_in_post_types_jobs":"0","built_in_post_types_testimonial":"0","built_in_post_types_team_member":"0","built_in_post_types_applicants":"0","built_in_post_types_test":"0","built_in_post_types_testimonials":"0","built_in_post_types_tasks":"0","built_in_post_types_placement":"0","built_in_post_types_placements":"0"},"436":{"id":436,"name":"job_categories","label":"Job Categories","description":"","type":"taxonomy","storage":"meta","object":"","alias":"","fields":[],"show_in_menu":"1","label_singular":"Job Category","public":"1","show_ui":"1","hierarchical":"1","rewrite":"1","rewrite_with_front":"1","rewrite_hierarchical":"1","capability_type":"custom","capability_type_custom":"job_category","query_var":"1","sort":"0","built_in_post_types_custom_css":"0","built_in_post_types_customize_changeset":"0","built_in_post_types_jobs":"1","built_in_post_types_oembed_cache":"0","built_in_post_types_page":"0","built_in_post_types_post":"0","built_in_post_types_testimonials":"0","built_in_post_types_attachment":"0","menu_location":"default","show_in_nav_menus":"1","show_tagcloud":"1","show_tagcloud_in_edit":"1","show_in_quick_edit":"1","show_admin_column":"1","pfat_enable":"0","pfat_run_outside_loop":"0","pfat_append_archive":"append","rest_enable":"0","read_all":"0","write_all":"0","built_in_post_types_applicants":"0","built_in_post_types_team_member":"0","built_in_post_types_wpcf7_contact_form":"0","built_in_post_types_placement":"0","built_in_post_types_placements":"0"},"412":{"id":412,"name":"jobs","label":"Jobs","description":"","type":"post_type","storage":"meta","object":"","alias":"","fields":{"job_number":{"id":414,"name":"job_number","label":"Job Number","description":"","help":"","class":"","type":"text","weight":0,"pick_object":"","pick_val":"","sister_id":"","required":"1","text_allow_shortcode":"0","text_allow_html":"0","text_allowed_html_tags":"strong em a ul ol li b i","text_max_length":"255","pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","text_repeatable":"0","text_placeholder":""},"minimum_experience":{"id":418,"name":"minimum_experience","label":"Minimum Experience","description":"","help":"","class":"","type":"pick","weight":1,"pick_object":"custom-simple","pick_val":"","sister_id":"","required":"1","pick_format_type":"single","pick_format_single":"radio","pick_format_multi":"checkbox","pick_allow_add_new":"1","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_custom":"Experienced Only\nMid Level\nEntry Level\nJourney Level","default_value":"Experienced Only","default_value_parameter":"Experienced Only","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""},"position_type":{"id":428,"name":"position_type","label":"Position Type","description":"","help":"","class":"","type":"pick","weight":2,"pick_object":"custom-simple","pick_val":"","sister_id":"","pick_custom":"Full-Time|Full-Time\nPart-Time|Part-Time","required":"1","pick_format_type":"single","pick_format_single":"radio","pick_format_multi":"checkbox","pick_allow_add_new":"1","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"default_value":"Full-Time","default_value_parameter":"Full-Time","admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""},"city_or_county":{"id":416,"name":"city_or_county","label":"City or County","description":"","help":"","class":"","type":"text","weight":3,"pick_object":"","pick_val":"","sister_id":"","required":"1","text_allow_shortcode":"0","text_allow_html":"0","text_allowed_html_tags":"strong em a ul ol li b i","text_max_length":"255","pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","text_repeatable":"0","text_placeholder":""},"state":{"id":417,"name":"state","label":"State","description":"","help":"","class":"","type":"pick","weight":4,"pick_object":"custom-simple","pick_val":"","sister_id":"","required":"1","pick_format_type":"single","pick_format_single":"dropdown","pick_format_multi":"checkbox","pick_allow_add_new":"1","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"default_value":"WA","admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_custom":"WA|WA\nAK|AK\nCA|CA\nID|ID\nMT|MT\nOR|OR\n","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""},"job_counselor":{"id":552,"name":"job_counselor","label":"Counselor","description":"","help":"","class":"","type":"pick","weight":5,"pick_object":"post_type","pick_val":"team_member","sister_id":"1662","required":"1","pick_format_type":"single","pick_format_single":"dropdown","pick_format_multi":"checkbox","pick_allow_add_new":"0","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"admin_only":"0","restrict_role":"1","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator","counselor"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""}},"show_in_menu":"1","label_singular":"Job","public":"1","show_ui":"1","supports_title":"1","supports_editor":"1","publicly_queryable":"1","exclude_from_search":"0","capability_type":"custom","capability_type_custom":"job","capability_type_extra":"1","has_archive":"0","hierarchical":"0","rewrite":"1","rewrite_with_front":"1","rewrite_feeds":"0","rewrite_pages":"1","query_var":"1","can_export":"1","default_status":"draft","supports_author":"0","supports_thumbnail":"0","supports_excerpt":"0","supports_trackbacks":"0","supports_custom_fields":"0","supports_comments":"0","supports_revisions":"0","supports_page_attributes":"1","supports_post_formats":"1","built_in_taxonomies_category":"0","built_in_taxonomies_link_category":"0","built_in_taxonomies_post_tag":"0","show_in_nav_menus":"0","show_in_admin_bar":"1","pfat_enable":"1","pfat_run_outside_loop":"0","pfat_append_single":"replace","pfat_filter_single":"the_content","pfat_append_archive":"append","pfat_filter_archive":"the_content","rest_enable":"0","read_all":"1","write_all":"0","pfat_single":"Job Template","menu_icon":"dashicons-portfolio","label_archives":"All Jobs","built_in_taxonomies_applicant_categories":"0","built_in_taxonomies_job_categories":"1","name_admin_bar":"New Job"},"807":{"id":807,"name":"team_member","label":"Team Members","description":"","type":"post_type","storage":"meta","object":"","alias":"","fields":{"placement_counselor":{"id":833,"name":"placement_counselor","label":"Placement Counselor","description":"","help":"","class":"","type":"boolean","weight":0,"pick_object":"","pick_val":"","sister_id":"","required":"1","pick_post_status":["publish"],"boolean_format_type":"radio","boolean_yes_label":"Yes","boolean_no_label":"No","default_value":"Yes","admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0"},"email_address":{"id":834,"name":"email_address","label":"Email Address","description":"","help":"","class":"","type":"email","weight":1,"pick_object":"","pick_val":"","sister_id":"","required":"0","email_max_length":"255","email_html5":"0","pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","email_repeatable":"0","email_placeholder":""},"jobs":{"id":1662,"name":"jobs","label":"Jobs","description":"","help":"","class":"","type":"pick","weight":2,"pick_object":"post_type","pick_val":"jobs","sister_id":"552","required":"0","pick_format_type":"multi","pick_format_single":"dropdown","pick_format_multi":"checkbox","pick_allow_add_new":"0","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""},"applicants":{"id":1663,"name":"applicants","label":"Applicants","description":"","help":"","class":"","type":"pick","weight":3,"pick_object":"post_type","pick_val":"applicants","sister_id":"562","required":"0","pick_format_type":"multi","pick_format_single":"dropdown","pick_format_multi":"checkbox","pick_allow_add_new":"0","pick_taggable":"0","pick_show_icon":"1","pick_show_edit_link":"1","pick_show_view_link":"1","pick_limit":"0","pick_user_role":[],"pick_post_status":["publish"],"admin_only":"0","restrict_role":"0","restrict_capability":"0","hidden":"0","read_only":"0","roles_allowed":["administrator"],"rest_read":"0","rest_write":"0","rest_pick_response":"array","rest_pick_depth":"2","unique":"0","pick_select_text":"","pick_table_id":"","pick_table_index":"","pick_display":"","pick_where":"","pick_orderby":"","pick_groupby":""}},"show_in_menu":"1","label_singular":"Team Member","public":"1","show_ui":"1","supports_title":"1","supports_editor":"1","publicly_queryable":"1","exclude_from_search":"0","capability_type":"page","capability_type_custom":"team_member","capability_type_extra":"1","has_archive":"0","has_archive_slug":"Car People Team","hierarchical":"0","rewrite":"1","rewrite_with_front":"1","rewrite_feeds":"0","rewrite_pages":"1","query_var":"1","can_export":"1","default_status":"draft","supports_author":"0","supports_thumbnail":"1","supports_excerpt":"1","supports_trackbacks":"0","supports_custom_fields":"0","supports_comments":"0","supports_revisions":"0","supports_page_attributes":"0","supports_post_formats":"0","built_in_taxonomies_applicant_categories":"0","built_in_taxonomies_category":"0","built_in_taxonomies_job_categories":"0","built_in_taxonomies_link_category":"0","built_in_taxonomies_post_tag":"0","show_in_nav_menus":"1","show_in_admin_bar":"1","pfat_enable":"0","pfat_run_outside_loop":"0","pfat_single":"Applicant Template","pfat_append_single":"append","pfat_filter_single":"the_content","pfat_append_archive":"append","pfat_filter_archive":"the_content","rest_enable":"0","read_all":"0","write_all":"0","menu_icon":"dashicons-groups"}}}

Todos

WordPress Environment

``` Debug Information WordPress Version: 4.9.5 PHP Version: 7.1.14 MySQL Version: 5.6.39 Server Software: Apache Your User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 Session Save Path: /tmp Session Save Path Exists: Yes Session Save Path Writeable: Yes Session Max Lifetime: 1440 Opcode Cache: Apc: No Memcached: No OPcache: No Redis: No Object Cache: APC: No APCu: No Memcache: No Memcached: No Redis: No WPDB Prefix: wp_ WP Multisite Mode: No WP Memory Limit: 40M Pods Network-Wide Activated: No Pods Install Location: /home/bekidjvn7s5d/public_html/wp-content/plugins/pods/ Pods Tableless Mode Activated: No Pods Light Mode Activated: No Currently Active Theme: Mesmerize PRO Currently Active Plugins: Add custom page template: 1.0 Archive Control: 1.3.3 Caldera Forms: 1.6.1 Custom Post Type Widgets: 1.1.3 Custom Sidebars: 3.1.3 Ferbit: Insert Pages: 3.4.1 Mesmerize Companion: 1.4.1 Pods - Custom Content Types and Fields: 2.7.1 Really Simple SSL: 2.5.26 SiteOrigin Widgets Bundle: 1.11.8 Smart Slider 3 Pro: 3.2.14 UpdraftPlus - Backup/Restore: 1.14.5 Way2enjoy Image Optimizer: 2.1.0.16 WP Fastest Cache: 0.8.7.9 ```
jimtrue commented 6 years ago

@ferbit Did you do the Javascript Console test to see if you were seeing errors when were logged in as the users? What are you using for defining your Custom Roles?

jimtrue commented 6 years ago

@ferbit Found them! You dragged them into the area where the Package Export went. I fixed it.

jimtrue commented 6 years ago

@ferbit Can you do a simple test for me? Disable your other plugins except for Pods and see if it works properly for your users and then re-enable plugins one at a time until you find the one that conflicts. I'm seeing lots of errors above, but not a single name of a plugin :(

ferbit commented 6 years ago

Will do.

jimtrue commented 6 years ago

Thanks!!

ferbit commented 6 years ago

It's Caldera. I didn't deactivate all of my plugins, I just did that one because I remember updating it this morning. JS errors immediately stopped and all select fields loaded properly

jimtrue commented 6 years ago

Did it give a specific error with Caldera? I find it weird that logging in as Admin would make it not show the errors, though.

Does it sound like this error? https://github.com/CalderaWP/Caldera-Forms/issues/2448

ferbit commented 6 years ago

No, I don't see any errors like that. But yes, very odd. When I'm logged in as admin, I don't see any errors at all and am able to see select boxes just fine. But when logged in as one of my users with a custom role, only disabling the caldera plugin fixes it.

jimtrue commented 6 years ago

@ferbit My suggestion would be to bug this over at Caldera Forms and mention this GitHub ticket as well. We've been working very hard to make sure our jQuery is properly namespaced, so this might be something that was a compatibility issue with this update at CalderaForms.

ferbit commented 6 years ago

Apologies, but how do I "bug this over" to Caldera Forms? Do I start a new post and link to this one? Thanks so much for your help @jimtrue !

jimtrue commented 6 years ago

Yep @ferbit You'd open a new issue at their GitHub: https://github.com/CalderaWP/Caldera-Forms/issues/new and then just copy a link to this one in that one. That way @Shelob9 is aware of the issue.

0xLBF commented 6 years ago

I had the same JavaScript errors but in the Pods Template editor (WP 4.9.6, Caldera 1.6.3, Pods 2.7.3). This patch fixed it for me: https://github.com/CalderaWP/Caldera-Forms/pull/2535 .

jimtrue commented 6 years ago

Looks like you fixed Caldera Forms, huh @0xLBF ?

0xLBF commented 6 years ago

Quite possibly, but @Shelob9 probably needs to properly rebuild the .min.js files, not edit them directly like I did.

jimtrue commented 6 years ago

Since this one actually has nothing to do with us, I'm closing it as there's nothing we can do on our side to prevent whatever is causing the issue in Caldera Forms.