Closed GaryJones closed 3 years ago
PR #4984 fixes:
Issue #4983 is specifically to consider:
Since they will be quite large, I'll open new PRs for:
Is this one complete and closed by #4984?
I'd like to open at least one or two PRs for WordPress.WP.I18n.MissingTranslatorsComment
and WordPress.WP.I18n.MissingArgDomain
, but if you want those under separate Issues to keep the discussion focused, then this ticket can be closed.
This is definitely an exception case where it makes sense to leave the issue open and do it in stages, works for me.
@GaryJones What is the status on this topic?
I've got no intent to make any PRs at this time, so feel free to takeover or close out.
Closing for now, we can continue to work on phpcs fixes going forward.
Now that the textdomain has been set for PHPCS, a new set of violation checks have appeared:
Some of the violations may not be valid, but should still be addressed by ignoring them where appropriate so that they don't appear in future scans.
I'll do one or more PRs that address these, so that translators can do a better job of / have an easier time adding translations.