Closed ghost closed 5 years ago
JoryHogeveen
commented
5 years ago @agaved
I've tested your issue locally and can't reproduce what you describe. Are you sure your locale is correct? Since there are various spanish locales available it might be possible that the locale that the user has selected isn't es_ES but another spanish locale.
I did created a PR for the i18n component to add the WP 5.0 labels.
JoryHogeveen
commented
5 years ago I just noticed one thing in your steps list:
Verify that the preferred language of the browser is not Portuguese
Please note that this component doesn't look at your browsers preference but at the user profile preference. The language of your browser doesn't change anything to this user preference.
If you want to take the browser locale into account you'll need to find/create a plugin that overwrites the WP locale according to the browser before any post types get registered.
ghost
commented
5 years ago Jory thanks for helping. I included this step because I wanted be sure that browser settings couldn't influence the outcome. I am perfectly fine using the user profile preference. Adriano
On 3 Jan, 2019, at 10:15, Jory Hogeveen notifications@github.com wrote:
I just notices one thing in your steps list:
Verify that the preferred language of the browser is not Portuguese
Please note that this component doesn't look at your browsers preference but at the user profile preference. The language of your browser doesn't change anything to this user preference. https://user-images.githubusercontent.com/826148/50637253-7fac1200-0f59-11e9-8293-00b184dc1f7d.png If you want to take the browser locale into account you'll need to find/create a plugin that overwrites the WP locale according to the browser before any post types get registered.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pods-framework/pods/issues/5259#issuecomment-451127243, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTuXMXRofQxAve5nYPCysyJecahzgcaks5u_fRmgaJpZM4Zl9nA.
-- Everything is possible, for people that don't know what is talking about.
ghost
commented
5 years ago On 3 Jan, 2019, at 10:08, Jory Hogeveen notifications@github.com wrote:
@agaved https://github.com/agaved I've tested your issue locally and can't reproduce what you describe. Are you sure your locale is correct? Since there are various spanish locales available it might be possible that the locale that the user has selected isn't es_ES but another spanish locale.
I checked in the WP db and indeed that user has es_ES as locale :/ Adriano
-- Everything is possible, for people that don't know what is talking about.
JoryHogeveen
commented
5 years ago Hi @agaved,
I found your issue. It used get_locale() instead of get_user_locale(). My method of testing just wasn't correct.
I've pushed a fix to this PR: https://github.com/pods-framework/pods/pull/5260
Branch: https://github.com/pods-framework/pods/tree/feature/5259-pods-i18n-wp5.0
Let me know if this also fixes your issue! Thanks, Jory
ghost
commented
5 years ago Hi @agaved https://github.com/agaved,
I found your issue. It used get_locale() instead of get_user_locale(). My method of testing just wasn't correct. I've pushed a fix to this PR: #5260 https://github.com/pods-framework/pods/pull/5260 Branch: https://github.com/pods-framework/pods/tree/feature/5259-pods-i18n-wp5.0 https://github.com/pods-framework/pods/tree/feature/5259-pods-i18n-wp5.0 Let me know if this also fixes your issue!
it worked like a charm. Thanks a lot. Adriano
-- Everything is possible, for people that don't know what is talking about.
JoryHogeveen
commented
5 years ago No problem!
pglewis
commented
5 years ago PR: #5260
Issue Overview
The labels in the Admin Pages appear in Portuguese (that is the site language), even if the user (in the WP user profile) and the browser have Spanish as their language.
Expected Behavior
The pod has its "Menu name" set for Portuguese and Spanish. The user has Spanish as its preferred language in Wordpress, and in its Firefox preferences. The user has capabilities to create/read/edit/delete the pod. The user accesses the Admin pages and sees the entry for the pod in the side menu in Spanish.
Current Behavior
The front end behaves as expected. The user accesses the Admin pages and sees the entry for the pod in the side menu in Portuguese.
Steps to Reproduce (for bugs)
Possible Solution
I have no idea.
WordPress Environment
Pods Package Export (helpful!)
Workaround or Alternate Solution Until Bug is Addressed
I published a Spanish only version, without any label translations for portuguese..
Related Issues and/or PRs