pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.
https://pods.io/
GNU General Public License v2.0
1.07k stars 264 forks source link

WYSIWYG text is not well formated in Elementor #5268

Open Luxamman opened 5 years ago

Luxamman commented 5 years ago

The text format from the pods WYSIWYG fields is not 1:1 transferred to Elementor (Pro) text field. Seems the problem is primarily with breaks and text paragraphs.

Could be a problem from pods framework? When using "plain text" in pods, the line breaks are used correctly.

Here a picture of the WYSIWYG pods input field: 50339980-5b901000-0519-11e9-9204-67d558fc2fa9

And here the final output: 50339977-57fc8900-0519-11e9-8900-d11cd609e9ca

You can see, the simple line breaks are ignored, also double breaks are converted in just white space between.

Steps to reproduce Create a pod, create a single template and include the WYSIWYG pods field into a Elementor single site text field.

Isolating the problem Not sure if the problem is Elementor or Pods related, but having the same issue on a different instance. Mentioned the problem also in the Elementor Repo: https://github.com/pojome/elementor/issues/6519#event-2048350490 Answer:

This could be due to the fact that by default we run all Pods field output via wp_kese_post() for obvious reasons. However, you can use the native Pods shortcode and use the dynamic shortcode tag for it. Still, a problem since we also run the output of the shortcode tag via wp_kese_post() but here you can disable it via a filter: add_filter( 'elementor_pro/dynamic_tags/shortcode/should_escape', '__return_false' );

Environment == Server Environment == Operating System: Linux Software: Apache/2.4.35 MySQL version: Source distribution v5.6.19-67.0 PHP Version: 7.2.3 PHP Max Input Vars: 1000 PHP Max Post Size: 50M GD Installed: Yes ZIP Installed: Yes Write Permissions: All right Elementor Library: Connected

== WordPress Environment == Version: 5.0.3 Site URL: http://dev.stadtquartier.at Home URL: http://dev.stadtquartier.at WP Multisite: No Max Upload Size: 50 MB Memory limit: 96M Permalink Structure: /%category%/%postname%/ Language: de-DE Timezone: Europe/Vienna Debug Mode: Inactive

== Theme == Name: Astra Version: 1.6.2 Author: Brainstorm Force Child Theme: No

jimtrue commented 5 years ago

@luxamman Can you verify the settings for your field in the additional options? Specifically, you're looking for Enable wpautop? Being checked, which is what does the proper paragraph wrapping and new line breaks.

Luxamman commented 5 years ago

wpautop enabled/disabled makes no difference in my example. Thanks!

jimtrue commented 5 years ago

Thank you! Needed that for clarification.

evij-g commented 5 years ago

any news to this issue?

jimtrue commented 5 years ago

Honestly, since Elementor is the one handling the display, I don't think this is a Pods issue at all: https://github.com/elementor/elementor/issues/6519#issuecomment-465641923

jimtrue commented 5 years ago

We do not typically modify the way our content is stored for different themes or theme display; we standardize the storage of our content across the board for consistency for WordPress standards (until we find that we're not doing that properly). I'm not sure why we would do that for a Page Builder, either.

sc0ttkclark commented 5 years ago

This does sound like it could be an Elementor specific issue.

Luxamman commented 5 years ago

Reopened the issue in Elementor https://github.com/elementor/elementor/issues/7611 because they closed it without a working solution whatever.

KeriCaraher commented 4 years ago

I am also having this problem. Has anyone found a solution??? It's been a year and a half...

sc0ttkclark commented 4 years ago

I don't have a copy of Elementor Pro unfortunately. It does seem to be something on their side, not working well with our clean handling of the render.

JoryHogeveen commented 4 years ago

I believe they provided a filter solution here: https://github.com/elementor/elementor/issues/7611#issuecomment-569479846

It's a pitty that they included half-working Pods support in their core code instead of a separate addon. This prevents us somewhat from creating/contributing compatibility code.

quasel commented 4 years ago

Added a comment over there - https://github.com/elementor/elementor/issues/7611#issuecomment-694746512

As mentioned - they run wp_kese_post() on the pods output…  let's see if they respond this time… 

simonclay commented 2 years ago

This still seems to be an issue. Paragraph breaks do not show in Pods WYSIWYG areas.

vgstef commented 1 month ago

I'm still struggling with this. Any news?