search

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.
https://pods.io/
GNU General Public License v2.0
1.07k stars 264 forks source link

Filter on shortcode disables template rendering #5374

Open worldoptimizer opened 5 years ago

worldoptimizer commented 5 years ago

Issue Overview

When using the [pods name="book" template="book_display"] everything works fine. When using the [pods name="book" template="book_display" filter="my_field"] no books are rendered anymore (using the template) even when transmitting the filter.

Expected Behavior

Render with filter using the template

Current Behavior

renders nothing

Steps to Reproduce (for bugs)

ad the filter on a pods shortcode using template

Possible Solution

WordPress Environment

``` Debug Information WordPress Version: 5.2 PHP Version: 7.1.23-nmm1 MySQL Version: 5.7.25 Server Software: Apache Your User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.131 Safari/537.36 Session Save Path: /tmp/phpfpmsessions/ Session Save Path Exists: Yes Session Save Path Writeable: Yes Session Max Lifetime: 1440 Opcode Cache: Apc: No Memcached: No OPcache: No Redis: No Object Cache: APC: No APCu: No Memcache: No Memcached: No Redis: No WPDB Prefix: c7w4n_ WP Multisite Mode: No WP Memory Limit: 40M Current Memory Usage: 49,787M Current Memory Usage (real): 26,000M Pods Network-Wide Activated: No Pods Install Location: /www/htdocs/w0122149/literaturbrichtmauern.de/wp-content/plugins/pods/ Pods Tableless Mode Activated: No Pods Light Mode Activated: No Currently Active Theme: GeneratePress Currently Active Plugins: Activity Log: 2.5.2 Adminimize: 1.11.4 Antispam Bee: 2.9.1 Brizy: 1.0.74 Brizy Pro: 0.0.25 Classic Editor: 1.4 Code Snippets: 2.13.3 Duplicate Post: 3.2.2 Enable Media Replace: 3.2.9 Envato Elements: 1.0.3 Force Login: 5.3 Login Designer: 1.1.11 Pods - Custom Content Types and Fields: 2.7.12 ShortPixel Image Optimizer: 4.13.1 UpdraftPlus - Backup/Restore: 1.16.14 Userback: 1.02 User Switching: 1.5.0 WP Mail SMTP: 1.4.2 ```

Pods Package Export (helpful!)

Copy and Paste the JSON Export from **Pods Admin, Migrate: Packages, Export** in WordPress admin here
issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label Type: Bug to this issue, with a confidence of 0.53. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

jamesgol commented 5 years ago

Cannot duplicate this. 'filter' doesn't even appear to be a valid parameter to pass to the shortcode, though 'filters' is. I even tried passing 'filters' in and did not reproduce the same behavior