Incorrect post id to pass into Filter pods_pods_field in REST API

coding-panda commented 5 years ago

Describe the bug When using the filter 'pods_pods_field' on normal pages, the four parameter $instance (object|Pods) (referred to here: http://hookr.io/filters/pods_pods_field/) will pass in the correct id, but with REST API, it seems to pass in the last available id only.

To Reproduce Steps to reproduce the behavior:

Install the pods with the package code below.
Add the following code to functions.php. This function will return the ids from the second and the fourth parameters instead of the value so we can see the error add_filter( 'pods_pods_field', 'pods_field_fn', 10, 4 );
function pods_field_fn( $value_ukn, $row_arr, $params_arr, $pods_obj ){ //print_r($params_arr->name); if( $params_arr->name == 'post_id' ){ return $pods_obj->id; } if( $params_arr->name == 'row_id' ){ return $row_arr['ID']; }

return $value_ukn; }
Add at least two radmon Sections.
Add wp-json/wp/v2/section/ to the url after the domain name
post_id should be the same as the id, but it is not.

Expected behavior In REST API, pods_pods_field should receive the correct current Pods object.

Screenshots http://www.codingpanda.co.uk/pprf/wp-json/wp/v2/section/ codingpanda co uk pprf wp json wp v2 section (3)

Pods Version

Please provide the version of Pods you are running: 2.7.12

WordPress Environment

WordPress Version: 5.2.1 PHP Version: 7.0.33 MySQL Version: 5.5.5 Server Software: Apache/2.4.39 (Unix) Your User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0 Session Save Path: /home/sites/codingpanda.co.uk/tmp/ Session Save Path Exists: Yes Session Save Path Writeable: Yes Session Max Lifetime: 1440 Opcode Cache: Apc: No Memcached: No OPcache: Yes Redis: No Object Cache: APC: No APCu: No Memcache: No Memcached: No Redis: No WPDB Prefix: ppde_ WP Multisite Mode: No WP Memory Limit: 40M Current Memory Usage: 34.826M Current Memory Usage (real): 38.000M Pods Network-Wide Activated: No Pods Install Location: /home/sites/codingpanda.co.uk/public_html/pprf/wp-content/plugins/pods/ Pods Tableless Mode Activated: No Pods Light Mode Activated: No Currently Active Theme: Twenty Seventeen Currently Active Plugins: Panda Pods Repeater Field: 1.4.1 Pods - Custom Content Types and Fields: 2.7.12

Pods Package Export (helpful!)

Additional context Add any other context about the problem here.

Possible Workaround If you have discovered a workaround, please include it below.

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label Type: Bug to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

JoryHogeveen commented 5 years ago

@coding-panda Using the method id() instead of the parameter fixes your issue.

However @sc0ttkclark, it looks like the fetch(), reset() methods etc. don't set the $id parameter in the Pods object at all. Might be a good idea to add the following to these methods before returning a value:

$this->id = $this->id()

Let me know and I'll create a PR.

sc0ttkclark commented 5 years ago

$this->id only gets set when pods() is intentionally called from a singular context via pods( 'pod_name', $id_or_slug ) or when calling $pod->fetch( $id_or_slug ). It does not store the current ID when in a fetch() loop etc. No PR necessary here, but in the future we may expand the Pods object to support context in a separate class property instead of relying solely on $this->id internally to track singular versus list.

JoryHogeveen commented 5 years ago

$this->id only gets set when pods() is intentionally called from a singular context via pods( 'pod_name', $id_or_slug ) or when calling $pod->fetch( $id_or_slug )

@sc0ttkclark Not entirely correct. $pod->fetch( $id ) does not set the id parameter. The REST handler uses fetch().

sc0ttkclark commented 5 years ago

Yeah sorry, I should have left the fetch() part out there, it gets setup by PodsData::__construct() which is only setup when you do the initial pods( 'pod_name', $id_or_slug ).

JoryHogeveen commented 5 years ago

Okidoki, closing this issue then!

pods-framework / pods