search

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.
https://pods.io/
GNU General Public License v2.0
1.07k stars 264 forks source link

Pods interferes with LearnDash queries (they send "format" and it is seen as a taxonomy if you have a "format" taxonomy) #5789

Closed 50inthe314 closed 4 years ago

50inthe314 commented 4 years ago

Issue Overview

When PODS is installed and running, a featureset of Learndash is blocked. Learndash is an Learning Management System for sending out educational series. Courses are by default organized by:

Where a course can have many classes, lessons, etc. They have a feature for backwards up the tree, where a class can be used by multiple courses, and this is the function that PODS is blocking

Expected Behavior

On the LearnDash course set-up page, you go to the course builder page, and all of the existing classes and lessons are available in the sidebar to add to the course

Current Behavior

The classes are not showing unless the PODS plugin is deactivated.

Steps to Reproduce (for bugs)

  1. Create a new course, and enter course builder
  2. Classes and lessons do not show up
  3. Deactivate Pods
  4. Classes show up

Possible Solution

WordPress Environment

WordPress Version: 5.4.2 PHP Version: 7.4.6 MySQL Version: 5.7.29 Server Software: Apache Your User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36 Session Save Path: /var/lib/php/sessions Session Save Path Exists: Yes Session Save Path Writeable: Yes Session Max Lifetime: 1440 Opcode Cache: Apc: No Memcached: No OPcache: No Redis: No Object Cache: APC: No APCu: No Memcache: No Memcached: Yes Redis: Yes WPDB Prefix: wp_ WP Multisite Mode: No WP Memory Limit: 40M Current Memory Usage: 31.705M Current Memory Usage (real): 24.000M Pods Network-Wide Activated: No Pods Tableless Mode Activated: No Pods Light Mode Activated: No Currently Active Theme: OceanWP Child - Clearent Campus Currently Active Plugins: Activity Log: 2.5.2 Admin Menu Editor: 1.9.5 Child Theme Configurator: 2.5.5 Conditional Menus: 1.1.8 Content Control: 1.1.4 Custom Post Type UI: 1.7.4 Download Manager: 5.1.17 Dynamic Visibility for Elementor: 3.0.1 Elementor: 2.9.14 Elementor Pro: 2.10.3 Force Regenerate Thumbnails: 2.0.6 Import and export users and customers: 1.15.7.2 LearnDash LMS: 3.2.2 LearnDash LMS - Notifications: 1.4.0 LearnDash LMS - Zapier Integration: 2.1.0 LearnDash ProPanel: 2.1.3.1 MailPoet 3 (New): 3.47.10 Manage Notification E-mails: 1.5.1 Media Library Organizer: 1.1.5 miniOrange SSO using SAML 2.0: 12.0.1 Ocean Extra: 1.6.4 Ocean Stick Anything: 1.0.4 Page Links To: 3.3.4 Pods - Custom Content Types and Fields: 2.7.21 Rank Math SEO: 1.0.45 Related Posts By Taxonomy: 2.7.3 Relevanssi: 4.7.2.1 Remove Dashboard Access: 1.1.3 Search & Filter - Elementor Extension: 1.0.4 Search & Filter Pro: 2.5.1 Search Exclude: 1.2.5 Sidebar Manager: 1.1.3 Site Kit by Google: 1.12.0 Tin Canny Reporting for LearnDash: 3.4.3 Ultimate Member: 2.1.6 Ultimate Member - Terms & Conditions: 2.1.2 Ultimate Member - User Bookmarks: 2.0.4 Uncanny Toolkit for LearnDash: 3.3.1 User Role Editor: 4.55.1 Wicked Folders: 2.17.2 WPDM - Box.com Explorer: 1.2.1 WPDM - Button Templates: 1.3.0 WPDM - Gutenberg Blocks: 1.3.9 WPDM - Import Filebase Data: 1.0 WPDM - Page Template: 1.1 WPForms Lite: 1.6.1 We need YOU in 2020 and beyond Things are changing for Pods and we want you to be a part of it! Our goal is to be fully funded by users like you. Help us reach our goal of 200 recurring donors in 2020. Learn More

Workaround or Alternate Solution Until Bug is Addressed

Manually duplicate courses.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label Type: Enhancement to this issue, with a confidence of 0.72. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

50inthe314 commented 4 years ago

I do have a dev account I can give access too for more troubleshooting

sc0ttkclark commented 4 years ago

Sent you a message on our Slack to further discuss troubleshooting access.

sc0ttkclark commented 4 years ago

After reviewing your staging site (thanks for that!) and the LearnDash code itself, I've determined there are a couple of things happening here:

So this can be easily worked around by not using the same taxonomy name that conflicts there. I would recommend you contact LearnDash support and send them this comment link so they can stop accidentally passing that argument to WP_Query (via lack of build_selector_query() logic there) in a future version. If they need it, they should namespace their custom query var arguments as necessary to prevent conflicts from people like you building cool stuff.