pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.
https://pods.io/
GNU General Public License v2.0
1.07k stars 264 forks source link

Errors thrown when activating in php 8.0.0 install. Seems freemius related. #5956

Closed oldrup closed 2 years ago

oldrup commented 3 years ago

Description

Pods shows the following error message when activated on my PHP 8.0.0 installation

`Deprecated: Required parameter $wrapper follows optional parameter $type in /home/oldrupdk/oldrup.net/wp-content/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-fs-logger.php on line 145

Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-includes/functions.php on line 6362

Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-admin/includes/misc.php on line 1310

Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/pods/vendor/freemius/wordpress-sdk/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-admin/admin-header.php on line 9`

Testing instructions

  1. Upgrade to PHP 8
  2. Have debug on in wp-config
  3. Activate Pods

Screenshots / screencast

image

Possible workaround

Downgrade to PHP 7.4

Pods version

Version 2.7.26

Other super helpful information

All issues seems related to the freemius sdk

WordPress Environment ``` ` ### wp-core ### version: 5.7-RC1 site_language: en_GB user_language: en_GB timezone: Europe/Copenhagen permalink: /%postname%/ https_status: true multisite: true user_registration: false blog_public: 1 default_comment_status: open environment_type: production user_count: 8 site_count: 3 network_count: 1 dotorg_communication: true ### wp-active-theme ### name: Blocksy (blocksy) version: 1.7.71 author: CreativeThemes author_website: https://creativethemes.com parent_theme: none theme_features: core-block-patterns, automatic-feed-links, title-tag, custom-logo, lifterlms-sidebars, boostify-header-footer, fl-theme-builder-headers, fl-theme-builder-footers, fl-theme-builder-parts, editor-gradient-presets, editor-color-palette, post-thumbnails, menus, html5, align-wide, customize-selective-refresh-widgets, header-footer-elementor, widgets theme_path: /home/oldrupdk/oldrup.net/wp-content/themes/blocksy auto_update: Disabled ### wp-themes-inactive (5) ### Divi: version: 4.8.0, author: Elegant Themes, Auto-updates disabled Twenty Nineteen: version: 1.9, author: WordPress Team, Auto-updates disabled Twenty Sixteen: version: 2.3, author: The WordPress Team, Auto-updates disabled Twenty Twenty: version: 1.6, author: the WordPress team, Auto-updates enabled Twenty Twenty-One: version: 1.1, author: the WordPress team, Auto-updates disabled ### wp-plugins-active (28) ### 3D FlipBook : Dflip Lite: version: 1.7.5.1, author: DearHive, Auto-updates disabled Activity Log: version: 2.6.1, author: Activity Log Team, Auto-updates disabled Admin Columns: version: 4.2.5, author: AdminColumns.com, Auto-updates disabled Admin Menu Editor: version: 1.9.8, author: Janis Elsts, Auto-updates disabled Advanced Custom Fields: version: 5.9.5, author: Elliot Condon, Auto-updates disabled Antispam Bee: version: 2.9.3, author: pluginkollektiv, Auto-updates disabled Asset CleanUp: Page Speed Booster: version: 1.3.7.5, author: Gabe Livan, Auto-updates disabled Bookly: version: 19.4, author: Bookly, Auto-updates disabled Clean Image Filenames: version: 1.3, author: Upperdog, Auto-updates disabled Code Snippets: version: 2.14.0, author: Code Snippets Pro, Auto-updates disabled Disable Comments: version: 2.1.0, author: WPDeveloper, Auto-updates disabled Easy FancyBox: version: 1.8.18, author: RavanH, Auto-updates disabled Formidable Forms: version: 4.09.06, author: Strategy11, Auto-updates enabled LiteSpeed Cache: version: 3.6.2, author: LiteSpeed Technologies, Auto-updates disabled Loco Translate: version: 2.5.0, author: Tim Whitlock, Auto-updates disabled LuckyWP Table of Contents: version: 2.1.4, author: LuckyWP, Auto-updates disabled MailPoet 3 (New): version: 3.60.1, author: MailPoet, Auto-updates enabled Manage Notification E-mails: version: 1.6.1, author: Virgial Berveling, Auto-updates disabled Related Posts By Taxonomy: version: 2.7.4, author: keesiemijer, Auto-updates disabled Simple Custom CSS and JS: version: 3.36, author: SilkyPress.com, Auto-updates disabled Simple Custom Post Order: version: 2.5.3, author: Colorlib, Auto-updates disabled The SEO Framework: version: 4.1.3, author: The SEO Framework Team, Auto-updates disabled WebP Express: version: 0.19.0, author: Bjørn Rosell, Auto-updates disabled Wordfence Security: version: 7.4.14, author: Wordfence, Auto-updates enabled WordPress Beta Tester: version: 3.1.0, author: Peter Westwood, Andy Fragen, Auto-updates disabled WP External Links: version: 2.48, author: WebFactory Ltd, Auto-updates disabled WPForms Lite: version: 1.6.5, author: WPForms, Auto-updates disabled WP Mail SMTP: version: 2.6.0, author: WPForms, Auto-updates disabled ### wp-plugins-inactive (39) ### Ajax Search Lite: version: 4.8.6, author: Ernest Marcinko, Auto-updates disabled Akismet Anti-Spam: version: 4.1.8, author: Automattic, Auto-updates disabled Avatar Privacy: version: 2.4.6, author: Peter Putzer, Auto-updates disabled Blocksy Companion: version: 1.7.63, author: CreativeThemes, Auto-updates disabled Content Aware Sidebars: version: 3.15.1, author: Joachim Jensen - DEV Institute, Auto-updates disabled Customizer Export/Import: version: 0.9.2, author: The Beaver Builder Team, Auto-updates disabled Enhanced Media Library: version: 2.8.2, author: wpUXsolutions, Auto-updates disabled EWWW Image Optimizer: version: 6.0.3, author: Exactly WWW, Auto-updates disabled File Manager Advanced: version: 3.7, author: modalweb, Auto-updates disabled File Renaming on upload: version: 2.4.1, author: Pablo S G Pacheco, Auto-updates disabled File Upload Types: version: 1.2.0, author: WPForms, Auto-updates disabled Fluent Forms: version: 3.6.65, author: Contact Form - WPManageNinja LLC, Auto-updates disabled Fonts Plugin | Google Fonts Typography: version: 2.5.3, author: Fonts Plugin, Auto-updates disabled Getwid: version: 1.6.9, author: MotoPress, Auto-updates disabled Gutenberg: version: 10.0.2, author: Gutenberg Team, Auto-updates disabled jQuery Manager for WordPress: version: 1.10.6, author: Remzi Cavdar, Auto-updates disabled Page scroll to id: version: 1.7.2, author: malihu, Auto-updates disabled Pods - Custom Content Types and Fields: version: 2.7.26, author: Pods Framework Team, Auto-updates disabled Polylang: version: 2.9.2, author: WP SYNTEX, Auto-updates disabled Post SMTP: version: 2.0.22, author: Yehuda Hassine, Auto-updates enabled Post Type Switcher: version: 3.2.0, author: John James Jacoby, Auto-updates disabled Really Simple SSL: version: 4.0.9, author: Really Simple Plugins, Auto-updates disabled Redirection: version: 5.0.1, author: John Godley, Auto-updates disabled Relevanssi: version: 4.11.0, author: Mikko Saari, Auto-updates disabled Safe SVG: version: 1.9.9, author: Daryll Doyle, Auto-updates disabled Save Post. Check Links.: version: 1.0.1, author: pluginkollektiv, Auto-updates disabled Stackable - Gutenberg Blocks: version: 2.14.0, author: Gambit Technologies, Inc, Auto-updates disabled TablePress: version: 1.12, author: Tobias Bäthge, Auto-updates disabled Temporary Login Without Password: version: 1.6.7, author: StoreApps, Auto-updates disabled Test jQuery Updates: version: 2.0.0, author: The WordPress Team, Auto-updates disabled WordPress Importer: version: 0.7, author: wordpressdotorg, Auto-updates disabled WordProof Timestamp: version: 2.9.6, author: WordProof, Auto-updates disabled WP-Matomo Integration: version: 1.0.24, author: André Bräkling, Auto-updates disabled WP-Optimize - Clean, Compress, Cache: version: 3.1.7, author: David Anderson, Ruhani Rabin, Team Updraft, Auto-updates disabled WP All Import: version: 3.5.6, author: Soflyy, Auto-updates disabled WP All Import Pro: version: 4.6.3, author: Soflyy, Auto-updates disabled WP Extended Search: version: 2.0.1, author: 5um17, Auto-updates disabled WP Fastest Cache: version: 0.9.1.5, author: Emre Vona, Auto-updates disabled WPFront User Role Editor: version: 2.14.4, author: Syam Mohan, Auto-updates disabled ### wp-media ### image_editor: WP_Image_Editor_GD imagick_module_version: Not available imagemagick_version: Not available file_uploads: File uploads is turned off post_max_size: 256M upload_max_filesize: 256M max_effective_size: 256 MB max_file_uploads: 20 gd_version: bundled (2.1.0 compatible) ghostscript_version: 9.25 ### wp-server ### server_architecture: Linux 4.18.0-147.8.1.el7h.lve.1.x86_64 x86_64 httpd_software: LiteSpeed php_version: 8.0.0 64bit php_sapi: litespeed max_input_variables: 15000 time_limit: 300 memory_limit: 512M max_input_time: 900 upload_max_filesize: 256M php_post_max_size: 256M curl_version: 7.72.0 OpenSSL/1.1.1h suhosin: false imagick_availability: false pretty_permalinks: true htaccess_extra_rules: true ### wp-database ### extension: mysqli server_version: 10.3.28-MariaDB client_version: mysqlnd 8.0.0 ### wp-constants ### WP_HOME: undefined WP_SITEURL: undefined WP_CONTENT_DIR: /home/oldrupdk/oldrup.net/wp-content WP_PLUGIN_DIR: /home/oldrupdk/oldrup.net/wp-content/plugins WP_MEMORY_LIMIT: 64M WP_MAX_MEMORY_LIMIT: 512M WP_DEBUG: true WP_DEBUG_DISPLAY: true WP_DEBUG_LOG: false SCRIPT_DEBUG: false WP_CACHE: true CONCATENATE_SCRIPTS: undefined COMPRESS_SCRIPTS: undefined COMPRESS_CSS: undefined WP_LOCAL_DEV: undefined DB_CHARSET: utf8 DB_COLLATE: undefined ### wp-filesystem ### wordpress: writable wp-content: writable uploads: writable plugins: writable themes: writable mu-plugins: writable ### luckywp-table-of-contents ### domVersion: 20031129 libxmlVersion: 2.9.7 intlVersion: 8.0.0 icuVersion: 67.1 settings: {"lwptoc_general":{"min":2,"depth":6,"hierarchical":true,"numeration":"decimalnested","numerationSuffix":"none","title":"Contents","toggle":true,"labelShow":"show","labelHide":"hide","hideItems":false,"smoothScroll":true,"smoothScrollOffset":24},"lwptoc_appearance":{"width":"auto","float":"none","titleFontSize":"default","titleFontWeight":"bold","itemsFontSize":"90%","colorScheme":"light","backgroundColor":null,"borderColor":null,"titleColor":null,"linkColor":null,"hoverLinkColor":null,"visitedLinkColor":null},"lwptoc_autoInsert":{"enable":false,"position":"beforefirstheading","postTypes":["post"]},"lwptoc_processingHeadings":{"postTypes":null},"lwptoc_misc":{"skipHeadingLevel":null,"skipHeadingText":null,"hashFormat":"asheading","hashConvertToLowercase":false,"hashReplaceUnderlinesToDashes":false,"wrapNoindex":false,"useNofollow":false,"showMetaboxPostTypes":null,"listMarkupTags":"div","containerClass":null}} ### wpforms ### version: 1.6.5 lite: Nov 8, 2020 @ 8:57am upload_dir: Writable db_tables: wp_wpforms_tasks_meta total_forms: 1 total_submissions: undefined ### wp_mail_smtp ### version: 2.6.0 license_key_type: lite debug: No debug notices found. db_tables: wp_wpmailsmtp_tasks_meta lite_install_date: Nov 8, 2020 @ 8:57am ````
oldrup commented 3 years ago

Hey!. This morning the plugin Content Aware Sidebars got an update, Fixing Freemius compatibility issues with PHP 8. It looks like the Freemius SDK has been updated. Not knowing anything about how Pods integrates with Freemius, there might be a chance that most of the errors reported could be fixed by upgrading Freemius.

sc0ttkclark commented 2 years ago

Closing as this is no longer a problem in Pods 2.8