fix: form ui label tooltip heading and anchor color contract (#7118)

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.

https://pods.io/

GNU General Public License v2.0

1.07k stars 264 forks source link

fix: form ui label tooltip heading and anchor color contract (#7118) #7119

Closed heybran closed 1 year ago

heybran commented 1 year ago

Description

Add color: inherit; to h3 and a of .qtip-content div, now heading and anchor link has good color contract ratio.

Related GitHub issue(s)

Fixes #7118

Testing instructions

Go to 'Pods Admin'
Click on 'Add New'
Click on 'Create New'
Hover 'Content Type' ? icon

Screenshots / screencast

Changelog text for these changes

PR checklist

[x] I have tested my own code to confirm it works as I intended.
[x] My code follows the WordPress Coding Standards.
[x] My code follows the WordPress Inline Documentation Standards.
[ ] My code includes automated tests for PHP and/or JS (if applicable).

what-the-diff[bot] commented 1 year ago

PR Summary

Enhanced Accessibility Through Better Color Contrast The changes in the _wizard.scss file are geared towards improving the color contrast for elements such as headings (h3 tag) and links (a tag), particularly within the 'qtip-content' class. This enhancement greatly boosts the readability of the text, thus making our site more accessible to users with vision impairments.

sc0ttkclark commented 1 year ago

This is great, I'd like to check and see if there are other qtip usages that need adjusting too and that they look right. Will keep this slated for the next release.

heybran commented 1 year ago

Cool, I can walk though qtip elements as well and see if there's more that needs adjustment.

heybran commented 1 year ago

Pushed another commit to fix tooltip reported here: https://github.com/pods-framework/pods/issues/7118#issuecomment-1646508702

sc0ttkclark commented 1 year ago

Thanks for your help @heybran!