Custom Settings Pages should support specifying a capability for access

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.

GNU General Public License v2.0

1.06k stars 265 forks source link

Problem to Solve

Right now, you must have access as a Pods admin (caps: pods, pods_content, or pods_edit_{pod_name}).

It would be great to override what capability check(s) are used for the Custom Settings Pages specifically.

Proposed Solution

Add a new option to the Pod edit screen for Settings pods so that you can choose from these capabilities:

Default: Anyone with access to pods, pods_content, or podsedit{pod_name} capabilities
Custom
- Specify the custom capability to reference for access

Possible Workaround

add_filter( 'pods_is_admin', 'my_custom_override_for_custom_settings_page_access', 10, 3 );

function my_custom_override_for_custom_settings_page_access( $has_access, $capabilities, $capability ) {
    $my_pod_name = 'my_pod_name_here';
    $my_custom_capability = 'my_custom_capability_here';

    if (
        in_array( 'pods_edit_' . $my_pod_name, $capabilities, true )
        && current_user_can( $my_custom_capability )
    ) {
        return true;
    }

    return $has_access;
}

Todos

[ ] Update access check in PodsAdmin::admin_menu() https://github.com/pods-framework/pods/blob/08d1c6aacd3328186ff3de81cb6b560ddd3dd487/classes/PodsAdmin.php#L477
[ ] Add two fields to \Pods\Admin\Config\Pod::get_fields() for Settings pods: capability_type and capability_type_custom

pods-framework / pods