Taxonomy Relationship Sync Option - Githubissues

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.

https://pods.io/

GNU General Public License v2.0

1.07k stars 264 forks source link

Taxonomy Relationship Sync Option #7334

Closed pdclark closed 3 weeks ago

pdclark commented 1 month ago

Description

A check for bidirectional relationships in pick.php->save() prevents the Sync associated taxonomy with this relationship option from running due to an early return statement.

The input for the Sync associated taxonomy with this relationship should likely be boolean rather than text.

Version

3.2.6

Testing Instructions

Create taxonomy.
Create content type.
Connect taxonomy to content type.
Add relationship field on content type to taxonomy.
Input field Sync associated taxonomy with this relationship is unclear; appears to have no effect.

Screenshots / Screencast

No response

Possible Workaround

Suggested:

Add check for taxonomy sync before return related to bidirectional fields.
Change Taxonomy sync field to boolean.

Possible follow-up:

Hide built-in Taxonomy UI if sync is turned on, as the UI on edit screen and Quick Edit will have no effect.

Site Health Information

No response

Pods Package

{
    "@meta": {
        "version": "3.2.6",
        "build": 1723757070
    },
    "settings": {
        "types_only": "0",
        "watch_changed_fields": "0",
        "metadata_integration": "0",
        "metadata_override_get": "0",
        "register_meta_integration": "0",
        "media_modal_fields": "0",
        "session_auto_start": "0",
        "dynamic_features_allow": "1",
        "dynamic_features_enabled": [
            "display",
            "form"
        ],
        "show_access_restricted_messages": "0",
        "show_access_admin_notices": "1",
        "dynamic_features_allow_sql_clauses": "0",
        "display_callbacks": "customized",
        "display_callbacks_allowed": "esc_attr,esc_html",
        "wisdom_opt_out": "1",
        "active_components": [
            "migrate-packages",
            "templates"
        ]
    },
    "pods": [
        {
            "name": "example_content_type",
            "id": 81,
            "label": "Example Content Types",
            "description": "",
            "type": "post_type",
            "storage": "meta",
            "label_singular": "Example Content Type",
            "public": "1",
            "show_ui": "1",
            "publicly_queryable": "1",
            "dynamic_features_allow": "inherit",
            "rest_enable": "1",
            "supports_title": "1",
            "supports_editor": "1",
            "_migrated_28": "1",
            "built_in_taxonomies_taxonomy_example": "1",
            "groups": [
                {
                    "name": "more_fields",
                    "id": 82,
                    "label": "More Fields",
                    "description": "",
                    "weight": 0,
                    "fields": [
                        {
                            "name": "taxonomy_relationship_field",
                            "id": 83,
                            "label": "Taxonomy Relationship Field",
                            "description": "",
                            "weight": 0,
                            "type": "pick",
                            "pick_object": "taxonomy",
                            "pick_val": "taxonomy_example",
                            "pick_format_type": "multi",
                            "pick_format_single": "dropdown",
                            "pick_format_multi": "list",
                            "pick_display_format_multi": "default",
                            "pick_display_format_separator": ", ",
                            "pick_allow_add_new": "1",
                            "pick_taggable": "0",
                            "pick_show_icon": "1",
                            "pick_show_edit_link": "1",
                            "pick_show_view_link": "1",
                            "pick_limit": "0",
                            "pick_user_role": "Administrator",
                            "pick_sync_taxonomy": "5,6",
                            "pick_post_status": "publish",
                            "pick_post_author": "0",
                            "repeatable": "0",
                            "repeatable_format": "default",
                            "default_evaluate_tags": "0",
                            "default_empty_fields": "0",
                            "roles_allowed": "administrator",
                            "revisions_revision_field": "0",
                            "enable_conditional_logic": "0",
                            "rest_pick_response": "array",
                            "rest_pick_depth": "1",
                            "required": "0",
                            "logged_in_only": "0",
                            "admin_only": "0",
                            "restrict_role": "0",
                            "restrict_capability": "0",
                            "hidden": "0",
                            "read_only": "0"
                        }
                    ]
                }
            ]
        },
        {
            "name": "taxonomy_example",
            "id": 79,
            "label": "Taxonomy Examples",
            "description": "",
            "type": "taxonomy",
            "storage": "meta",
            "label_singular": "Taxonomy Example",
            "public": "1",
            "show_ui": "1",
            "hierarchical": "1",
            "publicly_queryable": "1",
            "dynamic_features_allow": "inherit",
            "rest_enable": "1",
            "_migrated_28": "1",
            "built_in_post_types_example_content_type": "1",
            "show_in_quick_edit": "1",
            "show_admin_column": "1",
            "show_in_menu": "1",
            "menu_location": "default",
            "menu_position": "0",
            "show_in_nav_menus": "1",
            "show_tagcloud": "1",
            "show_admin_column_filter": "0",
            "groups": [
                {
                    "name": "more_fields",
                    "id": 80,
                    "label": "More Fields",
                    "description": "",
                    "weight": 0,
                    "fields": []
                }
            ]
        }
    ]
}

sc0ttkclark commented 3 weeks ago

Fixed via #7336