pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.

https://pods.io/

GNU General Public License v2.0

1.07k stars 264 forks source link

Relationship Field Sync Taxonomy: Checkbox & Unblock Sync #7336

Closed pdclark closed 3 months ago

pdclark commented 3 months ago

Description

Change taxonomy sync option from text to boolean.
Change bidirectional relationship check from preventing taxonomy sync feature from running due to early return

Related GitHub issue(s)

7334

Changelog text for these changes

Bug: Relationship Field Taxonomy Sync now works correctly and presents as checkbox. User Interface for taxonomies using this feature should be hidden in taxonomy Admin UI settings to avoid confusion, as changes relationship field will update core taxonomy, but core taxonomy user interfaces will not update relationship field. @pdclark

PR checklist

[x] I have tested my own code to confirm it works as I intended.
[x] My code follows the WordPress Coding Standards.
[x] My code follows the WordPress Inline Documentation Standards.
[ ] My code includes automated tests for PHP and/or JS (if applicable).

what-the-diff[bot] commented 3 months ago

PR Summary

Enriched the 'pick' Class A new 'type' attribute was added to the 'pick' class that categorizes it as 'boolean'. This means it will now accommodate only true or false values.
Added Default Value Handling A 'default' attribute was introduced into the 'pick' class which now defaults to '0'. Wherever there's no provided value for 'type', it will now default to '0'.
Enhanced Conditional Logic in 'if' Statement The logic inside an existing 'if' statement has been refined. Now, it has an additional check for whether certain options within the class are empty or not.
Code Re-arrangement for Efficiency Some pieces of code have been relocated within a conditional block. This likely ensures that these code pieces are only executed when necessary, increasing efficiency.

pdclark commented 3 months ago

@sc0ttkclark The change might have unexpected behavior for odd combinations of bidirectional fields AND taxonomy sync. Something to look at before editing further or committing the change. Perhaps would be easier to verify if the taxonomy sync and bidirectional sync logic were split into two new methods with necessary sanity checks at the start of each method.

sc0ttkclark commented 3 months ago