REST API Write access - Fix invalid default value

pods-framework / pods

The Pods Framework is a Content Development Framework for WordPress - It lets you create and extend content types that can be used for any project. Add fields of various types we've built in, or add your own with custom inputs, you have total control.

GNU General Public License v2.0

1.07k stars 264 forks source link

Description

De default value for the write_all option of a Pod was set to the Pod name. This results in incorrect parsing of a boolean in PodsRESTFields::field_allowed_to_extend() in write mode.

@sc0ttkclark See testing instructions. I'm not sure how you would like to implement something that will repair old Pods. You could check for ! empty() instead of using filter_var() but that might not be desirable.

Related GitHub issue(s)

Fixes #7327

Testing instructions

Create a Pod without this patch and enable write mode.
Go to PodsRESTFields::field_allowed_to_extend() and dump $all_fields_can_use_mode. It will return false, allways.
Verify with $pod->get_arg( $pod_mode_arg, 'value_not_set' ) and see it returns the Pod name instead of a 1 or 0.
Apply this patch
Disable REST write access and save Pod (important, otherwise it won't reset the value)
Re-enable REST Write access and save Pod.
Redo 1, 2 and 3 and you'll see it returns the correct values now.

PR checklist

[x] I have tested my own code to confirm it works as I intended.
[x] My code follows the WordPress Coding Standards.
[x] My code follows the WordPress Inline Documentation Standards.

PR Summary

Enhancements in REST API Options Several modifications took place in the set of options available for interacting with the REST API. This consists of alterations to the rest_base that allows customized endpoints, rest_namespace for custom namespace definitions, read_all and read_all_access for advanced viewing capabilities, write_all to allow updates over all fields, and rest_api_field_mode & rest_api_field_location for advanced field handling. The changes enhance the flexibility and control of API calls made to the service.

Bug Fix in PodsRESTFields.php The PR also includes a crucial bug fix for versions of Pods before 3.2.7. Previously, the default value for 'pod_mode' was incorrectly assigned to the pod name. This issue is now rectified with the update. This bug fix will improve reliability and prevent misbehavior in the application's function.

pods-framework / pods