podverse / podverse-rn

Podverse mobile app written in React Native for iOS, Android, and F-Droid
https://podverse.fm/about
GNU Affero General Public License v3.0
219 stars 36 forks source link

Increase custom RSS timeout from 30s to 60s to try to address errors when parsing large feeds (5MB+) #1297

Closed mitchdowney closed 2 years ago

mitchdowney commented 2 years ago

Source: https://podcastindex.social/@mitch/109104864761428239

So I was not able to reproduce the issue on our Google Play 4.6.7 version of the app...are you using 4.6.7? You can find the version number under More > About > scroll to the bottom.

My guess is this could be related to the size of the RSS feed and how long it takes to load...this feed is 4.9MB (quite big), and took 17.41s to load in my browser. Our custom RSS parser times-out after 30 seconds, so it's a possibility that it is just taking too long with our time-out.

I'm thinking about increasing the length of our custom RSS timeout from 30s to 60s...this is quite long for a network request, time out but I'm not sure how else to handle to a case like this.

If that doesn't solve it, then it might be related to how your specific device handles storage. The larger the file size, the more likely some Android devices will encounter issues saving the parsed version of the feed to the storage we are using.

regardless what the reason for the issue is, we should support large custom RSS feeds. I'll start by increasing the time out in the next release. If that doesn't resolve the issue for you, I may have to explore Android storage issues deeper.

mitchdowney commented 2 years ago

Should be in v4.6.9

https://github.com/podverse/podverse-rn/commit/5fcaf7812cbececa1dd8b4fecb12b4a1f628c1dc