podverse / podverse-rn

Podverse mobile app written in React Native for iOS, Android, and F-Droid
https://podverse.fm/about
GNU Affero General Public License v3.0
218 stars 36 forks source link

F-Droid scanner - DEBUG: Problem: found class 'com/google/ads/interactivemedia/v3/api/AdEvent' #2133

Closed licaon-kter closed 9 months ago

licaon-kter commented 10 months ago

Not sure where this comes from....

$ com.podverse.fdroid_100004/smali_classes2/com/google/ads/interactivemedia/v3/api $ cat *
.class public interface abstract Lcom/google/ads/interactivemedia/v3/api/AdEvent$AdEventListener;
.super Ljava/lang/Object;
.source "AdEvent.java"

# annotations
.annotation system Ldalvik/annotation/EnclosingClass;
    value = Lcom/google/ads/interactivemedia/v3/api/AdEvent;
.end annotation

.annotation system Ldalvik/annotation/InnerClass;
    accessFlags = 0x609
    name = "AdEventListener"
.end annotation

# virtual methods
.method public abstract onAdEvent(Lcom/google/ads/interactivemedia/v3/api/AdEvent;)V
.end method
.class public abstract Lcom/google/ads/interactivemedia/v3/api/AdEvent;
.super Ljava/lang/Object;
.source "AdEvent.java"

# annotations
.annotation system Ldalvik/annotation/MemberClasses;
    value = {
        Lcom/google/ads/interactivemedia/v3/api/AdEvent$AdEventListener;
    }
.end annotation

# direct methods
.method public constructor <init>()V
    .locals 0

    .line 5
    invoke-direct {p0}, Ljava/lang/Object;-><init>()V

    return-void
.end method

# virtual methods
.method public abstract getType()Landroidx/annotation/InspectableProperty;
.end method

related to https://github.com/podverse/podverse-fdroid/blob/4.15.4/android/build.gradle#L13 I guess

Is this a stub injected or?

Because it references something that is not FOSS https://mvnrepository.com/artifact/androidx.media3/media3-exoplayer-ima/1.2.0

licaon-kter commented 10 months ago

https://github.com/podverse/podverse-fdroid/blob/4.15.4/package.json#L108 -> https://github.com/react-native-video/react-native-video/blob/v6.0.0-beta.3/android/build.gradle#L168-L170

licaon-kter commented 10 months ago
$ com.podverse.fdroid_100004/smali/com/brentvatne $ grep "com/google/android/exoplayer2/ext/ima" -rin .
./exoplayer/ReactExoplayerView.smali:40:.field private adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:2554:    new-instance v3, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader$Builder;
./exoplayer/ReactExoplayerView.smali:2558:    invoke-direct {v3, v4}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader$Builder;-><init>(Lcom/facebook/react/uimanager/ThemedReactContext;)V
./exoplayer/ReactExoplayerView.smali:2560:    invoke-virtual {v3, p0}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader$Builder;->setAdEventListener(Ljava/lang/Object;)Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader$Builder;
./exoplayer/ReactExoplayerView.smali:2564:    invoke-virtual {v3}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader$Builder;->build()Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:2568:    iput-object v3, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:2660:    iget-object v0, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:2667:    invoke-virtual {v0, v2}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;->setPlayer(Landroidx/media3/exoplayer/ExoPlayer;)V
./exoplayer/ReactExoplayerView.smali:2859:    iget-object v2, v9, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:3327:    iget-object v0, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:3332:    invoke-virtual {v0, v1}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;->setPlayer(Landroidx/media3/exoplayer/ExoPlayer;)V
./exoplayer/ReactExoplayerView.smali:3356:    iget-object v0, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:3361:    invoke-virtual {v0}, Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;->release()V
./exoplayer/ReactExoplayerView.smali:3365:    iput-object v1, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:4413:    iget-object p1, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;
./exoplayer/ReactExoplayerView.smali:4422:    iget-object p1, p0, Lcom/brentvatne/exoplayer/ReactExoplayerView;->adsLoader:Lcom/google/android/exoplayer2/ext/ima/ImaAdsLoader;

which seem to be from https://mvnrepository.com/artifact/androidx.media3/media3-exoplayer-ima/1.2.0 😞

lovegaoshi commented 10 months ago

this is bizarre, https://github.com/podverse/podverse-rn/blob/26048c704086af64b422b7941b374320789ec152/android/build.gradle#L13 shows RNVUseExoplayerIMA = false might worth to raise to RNV

licaon-kter commented 10 months ago

I see that @mitchdowney took a look in that area in https://github.com/react-native-video/react-native-video/issues/3392

licaon-kter commented 9 months ago

Cleared as stubs :tada: