Closed Marzal closed 1 year ago
And now adding a tag with application/x-subrip
mime, the subs are shown
@Marzal I'll try to take a look at this issue this week. It might just be due to a simple bug / oversight...
Thanks, now that I have the transcripts working in the web client using application/x-subrip
, I've seen that in the Android App transcripts aren't working anyway, not in KDE Express Podcast neither in Podcasting 2.0 that uses only application/srt
Should I open a separate issue for that in its repo?
@Marzal could you create another issue in podverse-rn repo? And include a link to this issue in the description? If it's working in one but not the other that is odd...but also might point to a simple fix.
@Marzal unrelated to this ticket, but I see 2 instances of KDE Express in Podcast Index (and Podverse, because we sync with PI). Is that intended? If not, please email info@podcastindex.org and let them know which one should be removed.
@Marzal is this issue still reproducible in web or mobile after the mobile v4.13.6 update? If no, please close this ticket. Thanks
@Marzal unrelated to this ticket, but I see 2 instances of KDE Express in Podcast Index (and Podverse, because we sync with PI). Is that intended? If not, please email info@podcastindex.org and let them know which one should be removed.
Dave is aware of the duplicate, we are in works to fix it. Right now is a consequence of the framework generator that KDE Express uses. For context: https://github.com/skymethod/op3/discussions/16#discussioncomment-6712555
About the VTT, I will try to find another podcast that only uses VTT, or does Podverse refresh the cached feed every X hours/days?
Right now all episodes have both VTT and SRT so it's not a valid feed to test. And deleting the srt in one episode I'm not sure if it will works, as PI doesn't re-parse the old episodes (right know PI don't even show transcript in the most old ones).
I did ask Dave to refresh the feeds a few days and it worked, and I will have to asking again when I'm done with the changes I'm doing to the feed generator.
I'm also studding how podping works in case this will force a total refresh or the feed in PI and will make not necessary the manual intervention of Dave.
And about transcripts: https://podverse.fm/es/membership shows as I understand that this feature is only for the mobile apps (that's what I think the * means). But that is not true anymore, right?
@Marzal we don't have any special caching for transcripts as far as I know...if the url path to a transcript updates in an RSS feed, we just need to make sure the feed gets re-parsed so our client apps use the new transcript path.
Ok if you find a VTT we can test with please let me know.
And good catch on the membership asterisk! That is indeed out-of-date. I just deployed a fix to the website.
@mitchdowney as there is no cache I've just changed the feed in order to have episode 16 (the one that I originally linked ) with only vtt subs and the description to be able to check that is re-parsed.
How is the policy to re-parse the feeds? when a new episode / lastBuildDate is detected, the whole feed is reload?
@Marzal this is ugly, ugly code (our parser is probably the ugliest of all 🤦♂️) but here is the logic that controls whether if, when parsing a feed, a "change" is detected, and if a change is detected, then the parser will continue to parse the rest of the feed and update in our database. Our problem with updates is either 1) Podcast Index is not notifying us when a feed changes BUT does not have a new episode, or 2) this logic I am linking to has a flaw that results in it only working when a new episode is detected.
https://github.com/podverse/podverse-api/blob/develop/src/services/parser.ts#L320-L331
As for transcripts...I just ran our api locally so I could view error logs when I try to request a transcript directly.
Our API actually has a "priority" system that will use whichever transcript is available that is the "most reliable" or common according to what we've seen. In this case, even though episode 19 of KDE Express has a vtt
, the selected transcript file by priority was the following:
priorityTranscript {
url: 'https://op3.dev/e,pg=a9a56b87-575a-5f6f-9636-cdf7b73e6230/archive.org/download/19-kde-express-parati/19-KDE_Express-Parati.asr.srt',
type: 'application/srt',
language: 'es',
rel: 'captions'
}
When our API made a request to that API, it received the following error response:
502 - "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n<html xmlns=\"http://www.w3.org/1999/xhtml\">\n
\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\narchive.org - HTTP Error 502: Internal server error \n\n\n<body style=\"margin:0;padding:0;border:0;\">\n\n <div style=\"background-color:black;color:white;text-align:center;\">\n <img src=\"/about/logo.png\" alt=\"Internet Archive logo\" style=\"width:100px;height:100px;float:right;\"/>\n <br clear=\"right\"/>\n\n <h1 style=\"font-size:36px;margin-top:0;\">Sorry, we're kinda busy\n <a href=\"https://archive.org/details/MakingBo1947&start=348\">\n <img src=\"/about/busy.gif\" style=\"width:100%;height:auto;max-width:640px;\"/>\n \n
Please retry either now or later (by hitting refresh/reload).
\n\n
Describe the bug Transcripts won't show in a feed with vtt subtitles ¿Is vtt supported? It's mentioned in https://github.com/podverse/podverse-web/blob/2df1615d467980659a211835fdaa16d1b2b83202/src/lib/utility/transcript.ts#L8
To Reproduce Steps to reproduce the behavior:
getParsedTranscript error: TypeError: Data is not valid SRT format
Expected behavior Subtitles are shown or a warning about format not supported
Screenshots Example episode and error
Desktop (please complete the following information):
Additional context Android app doesn't show the subs also.