podverse / podverse-web

Podverse web app written with React and Next.js
https://podverse.fm/about
GNU Affero General Public License v3.0
81 stars 29 forks source link

Livestream pager links to empty section #1226

Open Marzal opened 10 months ago

Marzal commented 10 months ago

Describe the bug The logic behind the calculation of livestreams seems off

To Reproduce Clink on page number 4

Screenshots https://github.com/podverse/podverse-web/assets/2069735/24c5c9d1-94fc-46eb-8c96-45603ff1e113

mitchdowney commented 5 months ago

This issue happens because I am not actually querying for the page count before rendering the pagination button, so the UI is just guessing / loading by default as if there are 5+ pages. It's an ugly bug when you run into it...but I don't know how to query for a count of ALL the livestreams efficiently on each page load. I'd like to fix this, but it's also not one of the highest priorities right at the moment, so I'm going to unassign it from me for now.

Marzal commented 5 months ago

It a very low priority bug, no problem. In fact when you encounter it the workaround is obvious.

I reported it so it's documented, just that. Keep up the good work when is more important :muscle: