poebel / fceugc

Automatically exported from code.google.com/p/fceugc
0 stars 0 forks source link

Auto Detection of PAL/NTSC Games #235

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Describe the enhancement desired or suggested change:

I tested some PAL Games with FCEU GX (Kirby's Adventure is the best
example) and I always have to choose the correct Video Timing in the Menu 
(to have the right gaming speed).
FCEU (win) supports auto detection of roms (if they have the correct
header). It would be great if GX is supporting this feature in future, too.
Means, the user shall have the choice between video timing ntsc, pal and auto.

Original issue reported on code.google.com by starlord...@googlemail.com on 24 Dec 2009 at 9:43

GoogleCodeExporter commented 9 years ago
iNES format doesn't specify video timing, so this is impossible.
FCEUX windows (and this Wii port) checks the filename and sets timing according 
to 
that. However, I just realized I'm ALWAYS using the code below, even though 
timing 
is explicitly set. So I will add a third option Auto that uses the code below, 
and 
change the other two to NOT use the code below.

// since apparently the iNES format doesn't store this information,
    // guess if the settings should be PAL or NTSC from the ROM name
    // TODO: MD5 check against a list of all known PAL games instead?
    if(OverwriteVidMode)
    {
        if(strstr(name,"(E)") || strstr(name,"(e)")
            || strstr(name,"(F)") || strstr(name,"(f)")
            || strstr(name,"(G)") || strstr(name,"(g)")
            || strstr(name,"(I)") || strstr(name,"(i)"))
            FCEUI_SetVidSystem(1);
        else
            FCEUI_SetVidSystem(0);
    }

Original comment by dborth@gmail.com on 12 Apr 2010 at 8:28

GoogleCodeExporter commented 9 years ago
Great!
Could u add the possibility to hide the brackets and the letter.
Like the ".nes" is hide.
This would make the visuals better (imo).

For example: 
"Super Mario Bros (E).nes" -> "Super Mario Bros"
No hide if space is between dot and brackets 
"Super Mario Bros (E) .nes -> "Super Mario Bros (E)"

Original comment by starlord...@googlemail.com on 12 Apr 2010 at 9:14

GoogleCodeExporter commented 9 years ago
starlord:

IMHO that would not be a good change. What if you have both (U) and (E) roms of 
the 
same game? You should be able to differentiate which belongs to which region.

Original comment by axe...@gmail.com on 13 Apr 2010 at 2:09

GoogleCodeExporter commented 9 years ago
That's why I propose the alternative method.
If you are going to make spaces between the (E) and (U) the letters will be 
displayed.

But I believe the most people don't use/own more copies of the same game just 
from
different regions. :)

Original comment by starlord...@googlemail.com on 13 Apr 2010 at 6:45

GoogleCodeExporter commented 9 years ago

Original comment by dborth@gmail.com on 19 May 2010 at 10:09