poehlerj / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/2015/no-title-bar-forked/
GNU General Public License v2.0
67 stars 11 forks source link

Title bar remains on some windows on v4 #13

Open circuskid opened 4 years ago

circuskid commented 4 years ago

While overall I'd say the latest version is more consistant, especially with snaps, it refuses to remove the title bar on some apps that used to work in previous versions. Here's a screenshot example. Happy to provide further details if requested:

https://gyazo.com/7dc607dd3255317579e57d7a68e67cc3

poehlerj commented 4 years ago

@circuskid I was able to reproduce this with firestorm, at least "kinda". Most of the time it works, but sometimes, the extension sets the flag to hide the titlebar correctly (verified with xprop), but the window seems to ignore it. I'm not quite sure, what's going on, or what's really the difference to the old version that could cause this. I don't seem to have this behaviour on any other type of application (tried with Java/Intellij, Flatpack-installed, Browsers, etc.). Do you have more applications which don't behave as they should?

circuskid commented 4 years ago

@poehlerj I haven't noticed it on anything else, no. This might be the only native openGL app I have installed though (as in not wine/proton/etc). Not sure if that would make a difference. I have noticed that tabbing out of this app and back in the window kind of resize-flickers like it removes the bar and readds it quickly.

Like you said, everything else is much more consistent for me. Previous versions had problems with snaps that are gone now, so I really appreciate that.

poehlerj commented 4 years ago

Hmm, I found another application, which is broken, with the current build - this time completely. Fritzing seems to tell the window manager, it has window decorations (e.g. custom buttons in the titlebar), but doesn't do so. Thus v4 ignores the window. When I forcibly set the flags on that window, the titlebar just stays in place. So I think, that the window overrides/ignores it. Some more investigating showed, that other qt-based applications also show their titlebar, so i might need a fix for that.