poelstra / arduino-multi-button

Reliable detection of single, double and long clicks for Arduino.
MIT License
74 stars 15 forks source link

Does not work with Arduino Leonardo and Library Naming #3

Open woswos opened 5 years ago

woswos commented 5 years ago

Hello, I liked your work and exactly what I needed. However, the library doesn't work with Arduino Leonardo. I installed it as suggested and I tried running the example code. I have no idea why it doesn't work but I wanted to let you know.

I have another small suggestion. The repo name is "arduino-multi-button", library name is "MultiButton", and I see "PinButton.h" when I include the library. Maybe you can somehow unify the name so that it has the same name everywhere and less confusing.

Great job, congratulations again.

poelstra commented 5 years ago

Thanks for the kind words!

No clue why it wouldn't work for Leonardo. I'm only using standard Arduino functionality, so it should be portable across platforms. Don't have one, so can't test. If you do figure it out, I'm happy to accept a PR, though!

Yeah, the naming may be a bit confusing.

I could probably explain that a bit better in the README. I'll keep this as a reminder for when I do another update in the future.