Extending built-ins like Error, Array, and Map may no longer work

poelstra / ts-promise

TS-Promise - fast, robust, type-safe promises

MIT License

45 stars 4 forks source link

Extending built-ins like Error, Array, and Map may no longer work #14

Closed mgroenhoff closed 6 years ago

mgroenhoff commented 7 years ago

This is just a heads up because BaseError extends Error: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work

poelstra commented 7 years ago

Interesting. First, they actually fixed extending these, now they break it again. Have to think a bit how to best solve this, their recommendation still seems quite dirty.

Thanks for the heads up!

poelstra commented 6 years ago

Fixed in 1.0.0, thanks!