search

poem-web / poem

A full-featured and easy-to-use web framework with the Rust programming language.
Apache License 2.0
3.53k stars 283 forks source link

Add `cargo-semver-checks` to CI to ensure semver compliance #379

Open Christoph-AK opened 2 years ago

Christoph-AK commented 2 years ago

In the past we struggled with SemVer compliance (See #140, #169, #200, #246).

Today I read about cargo-semver-checks (also see the article on Predrags blog.)

Seems like it should be as simple as running the github action. We might want to run it on every tag, and tag all new versions according to the version in the Cargo.toml.

This doesn't entirely fix the problem, but should improve this going forward, especially as there are probably more SemVer-lints coming to the crate.

Might also want to enable http-registry in it once it lands.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Christoph-AK commented 2 years ago

I still want this. I would work on this if I find the time (if noone did it before, should be a really easy integration), so please leave this open for the time being.