search

poem-web / poem

A full-featured and easy-to-use web framework with the Rust programming language.
Apache License 2.0
3.62k stars 295 forks source link

fix: catch unwind for serve_connection #844

Closed tisonkun closed 4 months ago

tisonkun commented 4 months ago

This closes #843.

tisonkun commented 4 months ago

Tested locally. Work well.

attila-lin commented 4 months ago

Can this condition add a test case?

tisonkun commented 4 months ago

I don't know your test suites and conventions, so if you can add it or point the position of the cases, it would be helpful.

tisonkun commented 4 months ago

And you can trigger the CI so that we know if it introduces some regressions.

attila-lin commented 4 months ago

Looks fine. Thanks~

tisonkun commented 4 months ago

Thank you! Perhaps you can trigger a release so that I'd upgrade to the new version and run the regression tests in my project also :D