mod_mirrorbrain.c:506: possible bad test ?

[poeml]

                                                                                  [          ]

Issue migrated (2015-06-05) from old issue tracker http://mirrorbrain.org/issues/issue155

Title    mod_mirrorbrain.c:506: possible bad test ?
 Priority   bug          Status      chatting
Superseder              Nosy List    dcb, poeml
Assigned To poeml       Keywords

msg555 (view) Author: dcb Date: 2014-09-07.09:35:23

mod_mirrorbrain.c:506:30: warning: result of comparison against a string literal is unspecified (use strncmp instead) [-Wstring-compare]

  mrg->query = (add->query != (char *) DEFAULT_QUERY) ? add->query : base->query;

Duplicate also at two lines further down, line 508.

msg556 (view) Author: poeml Date: 2014-09-07.14:29:10

Interesting. This is code that merges Apache configurations, I think. I'll have to look into it. Thanks for the report!

History
         Date         User  Action            Args
                                   status: unread -> chatting
2014-09-07 14:29:10 poeml set    assignedto: poeml
                                   messages: + msg556
                                   nosy: + poeml
2014-09-07 09:35:25 dcb   create

(end of migrated issue)