Looking for rule ideas! 💡

poenneby / eslint-plugin-codeceptjs

Eslint rules for CodeceptJS

15 stars 12 forks source link

Looking for rule ideas! 💡 #1

Open poenneby opened 7 years ago

poenneby commented 7 years ago

This plugin is extremely simple as it currently only defines the globals in CodeceptJS. Here are some ideas of rules:

~~prefer_page_objects - Prevent the use of I within Scenario~~ ✅
missing_feature - Scenarios without Feature function call
missing_generator - Use of yield within a Scenario while missing generator function * declaration

Feel free to suggest others!

textbook commented 5 years ago

Rules around skipped and focused tests would be useful - for example, being able to make a focused test a lint error. (Skipped tests actually already are a lint error if you have no-undef on, as xScenario isn't in the globals...)

GabrielfLuchtenberg commented 5 years ago

It would help us on CI if we have some rule like " no only on scenarios"

poshaughnessy commented 5 years ago

Could there be a rule for no .only on a Scenario? (https://codecept.io/basics#skipping)

We sometimes add this to scenarios during debugging, but would like to make sure it's not checked in.

textbook commented 5 years ago

@GLuchtenberg @poshaughnessy I've added #11 and #12 for skipped and exclusive tests, respectively.

GabrielfLuchtenberg commented 5 years ago

Thanks @textbook I'll check!

Georgegriff commented 4 years ago

One of my colleagues just put out a pr for no pause if this is something might be interested in: https://github.com/poenneby/eslint-plugin-codeceptjs/pull/16

poenneby commented 4 years ago

Great idea! I will check it out. Thanks.

On Tue, Nov 19, 2019, 11:39 George Griffiths notifications@github.com wrote:

One of my colleagues just put out a pr for no pause if this is something might be interested in: https://github.com/poenneby/eslint-plugin-codeceptjs/pulls

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/poenneby/eslint-plugin-codeceptjs/issues/1?email_source=notifications&email_token=AAPXJEA3YHPITCYJUC362SLQUO66BA5CNFSM4C2A6HEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENW3PA#issuecomment-555445692, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPXJEDB24RCXTKX4AWCC73QUO66BANCNFSM4C2A6HEA .

kapilpau commented 4 years ago

We have been hit by .only in Data driven tests so extended no-exclusive-tests to check for that: #19 @poenneby

danielrentz commented 11 months ago

@poenneby I would like to see a rule no-todo-tests just like no-skipped-tests. https://codecept.io/basics/#todo-test