chore: Env vars Netlify

poetapp / explorer-web

Explore the Po.et Network and manage your API Tokens

https://explorer.poetnetwork.net/

MIT License

23 stars 9 forks source link

chore: Env vars Netlify #425

Closed wzalazar closed 5 years ago

wzalazar commented 5 years ago

PR Process - PR Review Checklist

Description of Changes

Fix https://github.com/poetapp/explorer-web/issues/426

This PR introduces:

Env vars for Netlify

Warning

Merging to master automatically triggers a deploy in production.

wzalazar commented 5 years ago

@jwicks31

When is necessary to read from?

https://github.com/poetapp/explorer-web/blob/9225834a9179246a3d03a8f5d130c5132f2ce2b4/webpack.config.js#L70-L76

I have a doubt here, Is possible to read deep keys? I mean limit and visiblePageCount

https://github.com/poetapp/explorer-web/blob/9225834a9179246a3d03a8f5d130c5132f2ce2b4/src/configuration.ts#L17-L26

jwicks31 commented 5 years ago

@wzalazar these environment variables are set inside of the Netlify already. I don't think it's necessary to add them to the TOML file. We are missing the DATE_FORMAT variable there though.

@jwicks31

When is necessary to read from?

https://github.com/poetapp/explorer-web/blob/9225834a9179246a3d03a8f5d130c5132f2ce2b4/webpack.config.js#L70-L76

I'm not sure how else to allow environment variables to be passed in individually?

wzalazar commented 5 years ago

@jwicks31 but the values are different for each environment. How you handle it on Netlify?

on the other hand, I didn't see these variables are set on Netlify

wzalazar commented 5 years ago

the issue was resolved ;)