UUID as Account.id - Githubissues

poetapp / frost-api

Po.et's API Layer

https://api.poetnetwork.net

MIT License

24 stars 5 forks source link

UUID as Account.id #905

Closed lautarodragan closed 5 years ago

lautarodragan commented 5 years ago

Finishes https://github.com/poetapp/frost-api/issues/919 Progress on https://github.com/poetapp/frost-api/issues/903

Changes

installs https://www.npmjs.com/package/uuid
introduces new id field for accounts
id is a uuid
POST /accounts now returns { id, issuer, token }
GET /accounts/:issuer now returns id
no breaking changes, but we'll need to run a migration to add id to all previous users

TODO

uuidToBytes? -> for a future PR, but it's just Buffer.from(uuid.replace(/-/g, ''), 'hex')
id: string, transform to/from Buffer at db level? -> need proper arch first, we have no real DAO :(

poet-ci commented 5 years ago

:tada: This PR is included in version 1.28.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: