search

poetapp / frost-api

Po.et's API Layer
https://api.poetnetwork.net
MIT License
24 stars 5 forks source link

Drop Vault.readSecret('frost') / write #906

Closed lautarodragan closed 5 years ago

lautarodragan commented 5 years ago

https://github.com/poetapp/frost-api/blob/4dc8bc745fc12b7dcfbbb4c6f0b8e59b9133b37b/src/utils/Vault/Vault.ts#L48-L54

Currently being used to store and read the JWT secret

https://github.com/poetapp/frost-api/blob/2da33582681fd7193f293d86ba24fecff25bc2d9/src/api/accounts/utils/utils.ts#L10-L17

https://github.com/poetapp/frost-api/blob/2da33582681fd7193f293d86ba24fecff25bc2d9/src/middlewares/authorization.ts#L21-L25

https://github.com/poetapp/frost-api/blob/2da33582681fd7193f293d86ba24fecff25bc2d9/src/initVault.ts#L46

Use an environment variable instead.

poet-ci commented 5 years ago

:tada: This issue has been resolved in version 1.29.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: