search

poetapp / frost-api

Po.et's API Layer
https://api.poetnetwork.net
MIT License
24 stars 5 forks source link

Tokens: Drop Email #916

Open lautarodragan opened 5 years ago

lautarodragan commented 5 years ago

This may break stuff in Explorer. Needs research.

lautarodragan commented 5 years ago

Alternatively we may be able to keep the email in the token and ignore it.

https://github.com/poetapp/frost-api/blob/e28856564a33f3beee0048f8e5c96a1c4849ed47/src/middlewares/authorization.ts#L25-L30

But it's also duplicated information which could be outdated and cause strange issues.

lautarodragan commented 5 years ago

The only remaining thing blocking this issue is letting the users know their API Keys will become obsolete and that they need to create new ones and use those instead.

Once that is done and this task is implemented, PATCH /accounts/:id { email: 'newemail@provider.com' } will work as expected.