poetapp / frost-api

Po.et's API Layer
https://api.poetnetwork.net
MIT License
24 stars 5 forks source link

chore(deps): update dependency node to v2.21.1 #980

Closed lautarodragan closed 5 years ago

lautarodragan commented 5 years ago

@WesleyCharlesBlake it looks like poet-node fails to start up.

$ dc up poet-node
frost-api_ipfs_1 is up-to-date
frost-api_mongo_1 is up-to-date
frost-api_bitcoind-1_1 is up-to-date
frost-api_rabbit_1 is up-to-date
Recreating frost-api_poet-node_1 ... done
Attaching to frost-api_poet-node_1
poet-node_1   | env: can't execute 'bash': No such file or directory
frost-api_poet-node_1 exited with code 127

Manually tried it with different versions, looks like it started happening with version v2.18.8.

I believe the associated PR is https://github.com/poetapp/node/pull/942.

BTW I'm trying this in my local machine, so I'm guessing it has nothing to do with CCI.

Wild guess: maybe the culprit is https://github.com/poetapp/node/pull/942/files#diff-3254677a7917c6c01f55212f86c57fbf?

Can you take a look?

WesleyCharlesBlake commented 5 years ago

@lautarodragan , I see whats going on. Since we use minimal alpine images, the container doesnt have a bash terminal, only sh. The wait for it script being run is for bash.

I'll fix this now

lautarodragan commented 5 years ago

Superseded by https://github.com/poetapp/frost-api/pull/982/files