search

poetapp / node

The core of Po.et
https://docs.poetnetwork.net/
MIT License
192 stars 27 forks source link

test: Functional test, Fork Detected #867

Closed wzalazar closed 5 years ago

wzalazar commented 5 years ago

PR Process - PR Review Checklist

Release

Semantic release is enabled for this repository. Make sure you follow the right commit message convention. We're using semantic-release's default — Angular Commit Message Conventions.

Description of Changes

Fix #679

This PR introduces:

lautarodragan commented 5 years ago

@wzalazar @warrenv tests are failing in Travis...

Deleting temporary DB (test-functional-node-poet-211-484-7)...
Connecting to temporary DB (mongodb://root:rootPass@mongo:27017/test-functional-node-poet-211-484-7)...
# Fork detected
(node:211) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'addNode' of undefined
    at riteway_1.describe (/usr/src/app/dist/babel/tests/functional/fork_detected.js:23:23)
(node:211) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:211) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
not ok 22 test exited without ending
  ---
    operator: fail
    at: process.<anonymous> (/usr/src/app/node_modules/tape/index.js:90:19)
    stack: |-
      Error: test exited without ending
          at Test.assert [as _assert] (/usr/src/app/node_modules/tape/lib/test.js:224:54)
          at Test.bound [as _assert] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at Test.fail (/usr/src/app/node_modules/tape/lib/test.js:317:10)
          at Test.bound [as fail] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at Test._exit (/usr/src/app/node_modules/tape/lib/test.js:190:14)
          at Test.bound [as _exit] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at process.<anonymous> (/usr/src/app/node_modules/tape/index.js:90:19)
          at process.emit (events.js:182:13)
  ...
not ok 23 test exited without ending
  ---
    operator: fail
    at: process.<anonymous> (/usr/src/app/node_modules/tape/index.js:90:19)
    stack: |-
      Error: test exited without ending
          at Test.assert [as _assert] (/usr/src/app/node_modules/tape/lib/test.js:224:54)
          at Test.bound [as _assert] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at Test.fail (/usr/src/app/node_modules/tape/lib/test.js:317:10)
          at Test.bound [as fail] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at Test._exit (/usr/src/app/node_modules/tape/lib/test.js:190:14)
          at Test.bound [as _exit] (/usr/src/app/node_modules/tape/lib/test.js:76:32)
          at process.<anonymous> (/usr/src/app/node_modules/tape/index.js:90:19)
          at process.emit (events.js:182:13)
  ...
1..23
# tests 23
# pass  21
# fail  2

I suspect this is an issue with the tests themselves.

wzalazar commented 5 years ago

@lautarodragan fixed ;)

wzalazar commented 5 years ago

@lautarodragan fixed, can you review again?

wzalazar commented 5 years ago

@lautarodragan changes done ;)

wzalazar commented 5 years ago

awesome, great feedback!!!

poet-ci commented 5 years ago

:tada: This PR is included in version 2.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: