search

poetapp / node

The core of Po.et
https://docs.poetnetwork.net/
MIT License
192 stars 27 forks source link

feature(API): add transactionAnchorInfo to health #872

Closed krobi64 closed 5 years ago

krobi64 commented 5 years ago

PR Process - PR Review Checklist

Release

Semantic release is enabled for this repository. Make sure you follow the right commit message convention. We're using semantic-release's default — Angular Commit Message Conventions.

Description of Changes

References #832

Add an IPFSDirectoryHashDAO to the API module and tie in the report to the GET /health endpoint

krobi64 commented 5 years ago

Is #874 a blocker? I knew this would need to be resolved so that we can truly separate the modules. I was already thinking about using RMQ to resolve this. There will be a similar DAO in the Health module, with the difference being that it inserts and updates entries, whereas this DAO only reads.

Refactoring this is a larger task.

@geoffturk what is the priority?

kennylavender commented 5 years ago

@krobi64 I am good with this being merged before #874 if @lautarodragan is.

I think it might be helpful to move the DAO to the Health module. API can import the DAO from Health, that should give us an easy way to see that we have broken the Module boundaries.

Edit: Looks like this DAO already exists in Health, so combining this DAO with the already existing DAO in Health might make sense.

lautarodragan commented 5 years ago

It's okay for API to directly access VIew's and Health's collections as long as it is read-only for now.

krobi64 commented 5 years ago

Closing in favor of a slightly different approach