search

poetapp / node

The core of Po.et
https://docs.poetnetwork.net/
MIT License
192 stars 27 forks source link

Possible Bitcoin Core fundRawTransaction Fee Error #887

Open lautarodragan opened 5 years ago

lautarodragan commented 5 years ago

Flagging this so we don't forget, but I don't know whether this is/leads to an error or what it means at all. Reported by @WesleyCharlesBlake originally, who caught this log:

2018-12-10T08:20:14Z [default wallet] Fee Calculation: Fee:1989 Bytes:186 Needed:1989 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (10401.3 - 10921.3) 95.95% 15735.7/(16397.6 0 mem 2.4 out) Fail: (9905.97 - 10401.3) 91.86% 32245.3/(35097.7 0 mem 3.4 out)

This seems to be thrown by estimateSmartFee (which is could be used under the hood by fundRawTransaction):

https://github.com/bitcoin/bitcoin/blob/234b99b9210c0a18fca10dfa75331a68f8e74a13/src/policy/fees.cpp#L882-L891

SomethingUseful commented 4 years ago

I am receiving tons of these "Conservative Double Target longer horizon" in v0.20.0. I receive none of these in v0.19.1

SomethingUseful commented 4 years ago

2020-07-01T06:48:48Z [default wallet] Fee Calculation: Fee:11378 Bytes:294 Needed:11127 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (36983.5 - 38832.7) 87.03% 1477. 5/(1697.0 0 mem 0.6 out) Fail: (35222.4 - 36983.5) 71.34% 665.2/(907.5 0 mem 25.1 out)

2020-07-01T06:52:15Z [default wallet] Fee Calculation: Fee:15385 Bytes:406 Needed:15368 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (36983.5 - 38832.7) 87.24% 1448. 3/(1659.5 0 mem 0.6 out) Fail: (35222.4 - 36983.5) 71.49% 645.0/(878.0 0 mem 24.1 out)

2020-07-01T07:33:18Z [default wallet] Fee Calculation: Fee:5161 Bytes:136 Needed:5152 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (36983.5 - 38832.7) 89.40% 1415.9/ (1583.3 0 mem 0.5 out) Fail: (35222.4 - 36983.5) 73.00% 551.2/(735.9 0 mem 19.1 out)

2020-07-01T13:15:44Z [default wallet] Fee Calculation: Fee:17378 Bytes:482 Needed:17378 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99520: Estimation: (35222.4 - 36983.5) 100.00% 8229.2/(8229.3 0 mem 0.0 out) Fail: (33545.1 - 35222.4) 94.96% 8901.2/(9373.3 0 mem 0.0 out)

2020-07-01T13:25:06Z [default wallet] Fee Calculation: Fee:9266 Bytes:257 Needed:9266 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99520: Estimation: (35222.4 - 36 983.5) 100.00% 8229.2/(8229.3 0 mem 0.0 out) Fail: (33545.1 - 35222.4) 94.96% 8901.2/(9373.3 0 mem 0.0 out)

2020-07-01T13:37:12Z [default wallet] Fee Calculation: Fee:11553 Bytes:315 Needed:11357 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99520: Estimation: (35222.4 - 36983.5) 100.00% 8229.2/(8229.3 0 mem 0.0 out) Fail: (33545.1 - 35222.4) 94.96% 8901.2/(9373.3 0 mem 0.0 out)